bugGPSD - Bugs: bug #47227, regress-driver may fail on binary...

 
 

bug #47227: regress-driver may fail on binary logs

Submitter:  Fred Wright <fhgwright>
Submitted:  Mon 22 Feb 2016 08:35:26 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 22 Feb 2016 08:35:26 PM UTC, original submission:  

This is already fixed, but I realized belatedly that I should have filed a tracking bug for it anyway.  From commit 8cfa92:

    Fixes manual use of regress-driver with binary logs.
   
    At present, running regress-driver manually on binary logs may fail,
    even though it works when run from scons.  This is due to running in
    an unsanitized environment when run manually.
   
    The problem is that sed is being used to filter the daemon output, and
    it's not really kosher to be using sed on binary data.  Whether the
    "working" cases involve its working "correctly" or merely
    "reproducibly" is unclear, but what is clear is that in can choke on
    binary data with certain settings of the LANG environment variable (in
    particular, "en_US.UTF-8" is known to fail on ac12_binary).  The fix
    is merely to unset LANG in regress-driver.
   
    Failures on binary data are also not very informative due to diff
    simply reporting "binary files differ".  That can be fixed by adding
    the -b option to diff, but the resulting output can contain characters
    that screw up the terminal, so it's probably not a good default.

This can be marked fixed.

Fred Wright <fhgwright>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by esr (Updated the item)
  • -email is unavailable- added by fhgwright (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-09-07 esr Open/ClosedOpen Closed
    2016-02-23 esr StatusNone Fixed

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code