bugGnash - The GNU Flash player - Bugs: bug #48066, Qt4 Gnash mistakenly sends...

 
 

bug #48066: Qt4 Gnash mistakenly sends `mouseDown` event when user right-clicked on the SWF

Submitter:  Nutchanon Wetchasit <nachanon>
Submitted:  Tue 31 May 2016 01:10:14 PM UTC
   
 
Category:  gui Severity:  3 - Normal
Release:  master Status:  Fixed
Privacy:  Public Assigned to:  strk
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 21 Jul 2016 10:27:20 AM UTC, comment #8: 

Well, as already said in comment 5, I had re-tested and the fix does work; this bug could be marked as fixed.

However, I have also found another unrelated issue in the process, and that issue (unimplemented context menu event, which affects all flavors of Gnash) will be posted as a new bug after I gathered enough information about it.

Sorry for causing confusion.

Nutchanon Wetchasit <nachanon>
Mon 18 Jul 2016 07:49:17 PM UTC, comment #7: 

It is for the original reporter to state if he's happy with the current solution, if it works for him. But your confirmation is also helpful :)

Sandro Santilli <strk>
Group Member
Mon 18 Jul 2016 06:07:34 PM UTC, comment #6: 

I'm not familiar with the procedure, here: Does "Ready for test" mean I (as code provider) should test, or is it for the provider of the original bug? (To me it seems to work fine :))

Dag Hovland <daghovland>
Sat 04 Jun 2016 04:16:06 PM UTC, comment #5: 

I have made another test Flash file to test Gnash's mouse click handling (both left click and right click), attached as `clipmouseupdown.zip`.

Test procedure are as follows:

  • Run `clipmouseupdown.swf`.
  • Right-click on the blue background (so context menu activates).
  • Left-click on other area of blue background (so context menu deactivates).
  • Left-click on the blue background again (testing left click).


Debug output from current `gtk-gnash` (verbosity 1 + action error log):

118 SECURITY: Checking security of URL 'file:///mnt/gnashdev/qt4-rightclick-problem/clipmouseupdown/clipmouseupdown.swf'
118 SECURITY: Load of file /mnt/gnashdev/qt4-rightclick-problem/clipmouseupdown/clipmouseupdown.swf granted (under local sandbox /mnt/gnashdev/qt4-rightclick-problem/clipmouseupdown/)
164 SECURITY: Extensions disabled
165 ACTIONSCRIPT ERROR: reference to non-existent variable 'ClipMouseUpDown'
6452 TRACE: stagemouseupdown: button pressed (199,57)
6452 TRACE: stagemouseupdown: pressed on movie (199,57)
6588 TRACE: stagemouseupdown: button released (199,57)
6588 TRACE: stagemouseupdown: released on movie (199,57)


Debug output from current `qt4-gnash` (verbosity 1 + action error log):

956 SECURITY: Checking security of URL 'file:///mnt/gnashdev/qt4-rightclick-problem/clipmouseupdown/clipmouseupdown.swf'
956 SECURITY: Load of file /mnt/gnashdev/qt4-rightclick-problem/clipmouseupdown/clipmouseupdown.swf granted (under local sandbox /mnt/gnashdev/qt4-rightclick-problem/clipmouseupdown/)
1304 ERROR: Can't update stage matrix till VM is initialized
1306 SECURITY: Extensions disabled
1340 ACTIONSCRIPT ERROR: reference to non-existent variable 'ClipMouseUpDown'
8247 TRACE: stagemouseupdown: button pressed (219,69)
8248 TRACE: stagemouseupdown: pressed on movie (219,69)
8335 TRACE: stagemouseupdown: button released (219,69)
8336 TRACE: stagemouseupdown: released on movie (219,69)


Trace output from Flash Player:

Failed to open VDPAU backend libvdpau_nvidia.so: cannot open shared object file: No such file or directory
Warning: Reference to undeclared variable, 'ClipMouseUpDown'
Failed to open VDPAU backend libvdpau_nvidia.so: cannot open shared object file: No such file or directory
stagemouseupdown: right button pressed (148,62)
stagemouseupdown: button pressed (148,62)
stagemouseupdown: pressed on movie (148,62)
stagemouseupdown: button released (100,63)
stagemouseupdown: released on movie (100,63)


I have also re-tested Hover Colorbars demo under current Qt4 Gnash, result is attached as . (You'd see that right-clicking on green column does not cause it to darken

As `clipmouseupdown.swf` under current Qt4 Gnash gives expected output in this aspect (one `mouseDown` followed by `mouseUp` at the end), and right-clicking on `hovercolorbars.swf` gives correct result, this bug could now be considered as fixed.

The other issue regarding missing context menu/right click event will be filed as a separate report. Thanks.

Gnash: 0.8.11dev (git f6a0b38 2-Jun-2016)
Flash Player: 11.2.202.491 Standalone
System: Debian GNU/Linux 7.0 Wheezy i386


(file #37386)

Nutchanon Wetchasit <nachanon>
Thu 02 Jun 2016 07:23:16 PM UTC, comment #4: 


Patch applied, please confirm it works now

Sandro Santilli <strk>
Group Member
Thu 02 Jun 2016 10:45:05 AM UTC, comment #3: 

I just now saw where to submit patches, so put it there also: https://savannah.gnu.org/patch/index.php?9015

Dag Hovland <daghovland>
Thu 02 Jun 2016 10:26:45 AM UTC, comment #2: 

This is fixed by adding a check for LeftButton in Qt4Glue.cpp DrawingWidget::mousePressEvent, e.g. like this:

void
DrawingWidget::mousePressEvent(QMouseEvent* event)
{
    if(Qt::LeftButton & event->button())
_gui.notifyMouseClick(true);
}

Patch attached

cheers,

Dag

(file #37351)

Dag Hovland <daghovland>
Tue 31 May 2016 01:22:28 PM UTC, comment #1: 

See attached screenshots for comparison:

  • `hovercolorbars_fp11.2.202.491.png` : Reference screenshot from Flash Player; you'd see that green column is bright.
  • `hovercolorbars_gtk-gnash0.8.11dev-5ad81af.png` : Screenshot from GTK+ Gnash; you'd see that green column is also bright.
  • `hovercolorbars_qt4-gnash0.8.11dev-5ad81af.png` : Screenshot from Qt4 Gnash; you'd see that green column is dark.


Gnash: 0.8.11dev (git 5ad81af 16-May-2016)
Flash Player: 11.2.202.491 Standalone
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>
Tue 31 May 2016 01:10:14 PM UTC, original submission:  

This is a minor issue, though annoying, it does not affect functionality.

While I was writing Qt-based XEmbed example involving `qt4-gnash`, I noticed that right-clicking on the SWF running under `qt4-gnash` does not only bring up the context menu, it also send `mouseDown` event to the underlying SWF.

This is undesirable as it would trigger unwanted operations in the SWF when user's intention was just to bring up player's context menu.

Exact steps to reproduce:

  • Run `hovercolorbars.swf` (obtained from file #37302) using `qt4-gnash`.
  • Move mouse over the green color bar, you'll see that its color brighten.
  • Right-click, you'd see that the green color bar darkens (in response to `mouseDown` event).


This problem is specific to `qt4-gnash`. Right-click menu on `gtk-gnash` does not have the problem. `sdl-gnash` and `fb-gnash` are not affected as they don't have right-click menu.

Gnash: 0.8.11dev (git 5ad81af 16-May-2016)
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #37386:  clipmouseupdown.zip added by nachanon (2KiB - application/zip - Left/right mouse click test Flash file and souce code)
file #37385:  hovercolorbars_qt4-gnash0.8.11dev-f6a0b38.png added by nachanon (4KiB - image/png - Screenshot of `hovercolorbars.swf` with right-click menu, under `qt4-gnash` 0.8.11dev git f6a0b38 2-Jun-2016)
file #37351:  rightclick.patch added by daghovland (452B - text/x-patch - Patch for Qt4 left click filter)
file #37318:  hovercolorbars_qt4-gnash0.8.11dev-5ad81af.png added by nachanon (4KiB - image/png - Screenshot of `hovercolorbars.swf` with right-click menu, under `qt4-gnash` 0.8.11dev git 5ad81af 16-May-2016)
file #37317:  hovercolorbars_gtk-gnash0.8.11dev-5ad81af.png added by nachanon (6KiB - image/png - Screenshot of `hovercolorbars.swf` with right-click menu, under `gtk-gnash` 0.8.11dev git 5ad81af 16-May-2016)
file #37316:  hovercolorbars_fp11.2.202.491.png added by nachanon (7KiB - image/png - Screenshot of `hovercolorbars.swf` with right-click menu, under Flash Player 11.2.202.491)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by daghovland (Updated the item)
  • -email is unavailable- added by nachanon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-07-21 strk StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2016-06-04 nachanon Attached File- Added clipmouseupdown.zip, #37386
    2016-06-04 nachanon Attached File- Added hovercolorbars_qt4-gnash0.8.11dev-f6a0b38.png, #37385
    2016-06-02 strk StatusNone Ready For Test
        Assigned toNone strk
    2016-06-02 daghovland Attached File- Added rightclick.patch, #37351
    2016-05-31 nachanon Attached File- Added hovercolorbars_qt4-gnash0.8.11dev-5ad81af.png, #37318
    2016-05-31 nachanon Attached File- Added hovercolorbars_gtk-gnash0.8.11dev-5ad81af.png, #37317
    2016-05-31 nachanon Attached File- Added hovercolorbars_fp11.2.202.491.png, #37316

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code