lwIP - A Lightweight TCP/IP stack - Bugs: bug #48308, Warnings in PPP Van Jacobson code...
You are not allowed to post comments on this tracker with your current authentication level.
bug #48308: Warnings in PPP Van Jacobson code when compiling with clang
Submitter: | Dirk Ziegelmeier <dziegel> | ||
Submitted: | Fri 24 Jun 2016 07:27:54 PM UTC | ||
Category: | PPP | Severity: | 3 - Normal |
Item Group: | Compiler Warning | Status: | Fixed |
Privacy: | Public | Assigned to: | gradator |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Jump to the original submission
Wed 29 Jun 2016 08:11:12 PM UTC, comment #8: |
Dirk Ziegelmeier <dziegel> |
Tue 28 Jun 2016 09:03:46 PM UTC, comment #7: Yeah, the first warning is easy to fix, the problem are all the others :-)
|
Sylvain Rochet <gradator> |
Tue 28 Jun 2016 08:19:55 PM UTC, comment #6: I'll send an email via the list, I'm to bored to figure out how to escape the text (the "Rich markup" link above does not work) |
Dirk Ziegelmeier <dziegel> |
Tue 28 Jun 2016 08:18:02 PM UTC, comment #5: Just noticed the markup messed up most of the * indirections.
|
Dirk Ziegelmeier <dziegel> |
Tue 28 Jun 2016 08:11:44 PM UTC, comment #4: Yes, clang does not warn about casting from u16_t* to struct xxx. It complains about the first cast:
|
Dirk Ziegelmeier <dziegel> |
Tue 28 Jun 2016 08:07:12 PM UTC, comment #3: Correct me if I am wrong, but my analysis is that it is just pointer
|
Sylvain Rochet <gradator> |
Tue 28 Jun 2016 08:02:01 PM UTC, comment #2: Are you sure about your analysis? The warnings are about casting from an UNALIGNED PACKED struct (struct ip_hdr, struct tcp_hdr) to a u32_t* or u16_t* which would require proper alignment.
|
Dirk Ziegelmeier <dziegel> |
Tue 28 Jun 2016 07:12:26 PM UTC, comment #1: After investigating this, all of these warnings are about accesses on packed struct,
|
Sylvain Rochet <gradator> |
Fri 24 Jun 2016 07:27:54 PM UTC, original submission:
clang -g -Wall -DLWIP_DEBUG -pedantic -Werror -Wparentheses -Wsequence-point -Wswitch-default -Wextra -Wundef -Wshadow -Wpointer-arith -Wcast-qual -Wc++-compat -Wwrite-strings -Wold-style-definition -Wcast-align -Wmissing-prototypes -Wredundant-decls -Wnested-externs -Wno-address -Wunreachable-code -Wuninitialized -Wno-format -I. -I../../../.. -I../../../../../lwip/src/include -I../../../../ports/unix/include -c ../../../../../lwip/src/netif/ppp/vj.c
|
Dirk Ziegelmeier <dziegel> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 8 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-06-29 | dziegel | Status | Confirmed | Fixed | |
Open/Closed | Open | Closed | |||
2016-06-28 | dziegel | Status | Wont Fix | Confirmed | |
Open/Closed | Closed | Open | |||
2016-06-28 | gradator | Status | Confirmed | Wont Fix | |
Open/Closed | Open | Closed | |||
2016-06-26 | gradator | Status | None | Confirmed | |
Summary | Warnings in PPP van Jacobsen code when compiling with clang | Warnings in PPP Van Jacobson code when compiling with clang |
Powered by Savane 3.13-d3ae.
Corresponding source code
Patch works