lwIP - A Lightweight TCP/IP stack - Bugs: bug #50064, Zero-copy RX: ARP reply fails with...
You are not allowed to post comments on this tracker with your current authentication level.
bug #50064: Zero-copy RX: ARP reply fails with PBUF_REF
Submitter: | Daniel Elstner <danielk> | ||
Submitted: | Tue 17 Jan 2017 10:27:19 AM UTC | ||
Category: | ARP | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | dziegel |
Open/Closed: | Closed | Planned Release: | 2.0.2 |
lwIP version: | 2.0.0 |
Jump to the original submission
Wed 18 Jan 2017 01:04:05 PM UTC, comment #10: |
Dirk Ziegelmeier <dziegel> |
Wed 18 Jan 2017 12:49:05 PM UTC, comment #9: Now it works, great. Thanks a lot! |
Daniel Elstner <danielk> |
Wed 18 Jan 2017 12:44:55 PM UTC, comment #8: Sorry, used the wrong destination HW addr.
|
Dirk Ziegelmeier <dziegel> |
Wed 18 Jan 2017 12:34:44 PM UTC, comment #7: Just tested it and it doesn't work. Looking at Wireshark logs I can see ARP replies, but the Ethernet destination address is set to 00:00:00:00:00:00 so they end up nowhere. |
Daniel Elstner <danielk> |
Wed 18 Jan 2017 11:25:47 AM UTC, comment #6: I also vote to allocate a new PBUF |
Dirk Ziegelmeier <dziegel> |
Wed 18 Jan 2017 10:50:39 AM UTC, comment #5: No, its OK, etharp_raw() also has the AUTOIP special case built-in. |
Dirk Ziegelmeier <dziegel> |
Wed 18 Jan 2017 10:11:32 AM UTC, comment #4: Doesn't the fix break the LWIP_AUTOIP speciality of sending the response as broadcast?
|
Simon Goldschmidt <goldsimon> |
Wed 18 Jan 2017 09:16:03 AM UTC, comment #3: I pushed a fix, can you please test if it works for you, Daniel? |
Dirk Ziegelmeier <dziegel> |
Wed 18 Jan 2017 08:51:00 AM UTC, comment #2: Alternative 1: Removie the special case of reusing the received pbuf in etharp_input() and call etharp_raw() to create ARP response. This is less performant, but saves some code bytes. Is there a reason for optimizing the ARP reply case?
|
Dirk Ziegelmeier <dziegel> |
Tue 17 Jan 2017 11:16:41 AM UTC, comment #1: I messed it up in commit 31778193da09a4394749ed3d5cc20aa35c418b1f
|
Dirk Ziegelmeier <dziegel> |
Tue 17 Jan 2017 10:27:19 AM UTC, original submission:
After implementing zero-copy DMA in my Ethernet driver with custom PBUF_REF pbufs, ARP replies stopped working.
|
Daniel Elstner <danielk> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-01-18 | dziegel | Status | Ready For Test | Fixed | |
Open/Closed | Open | Closed | |||
2017-01-18 | dziegel | Assigned to | None | dziegel | |
2017-01-18 | dziegel | Status | None | Ready For Test | |
Planned Release | None | 2.0.2 | |||
2017-01-17 | dziegel | Summary | ARP reply fails with PBUF_REF | Zero-copy RX: ARP reply fails with PBUF_REF |
Powered by Savane 3.13-f8d8.
Corresponding source code
Thanks for reporting and testing!