bugAVR Downloader/UploaDEr - Bugs: bug #51416, Bug when 'n' is typed after...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51416: Bug when 'n' is typed after "Would you like this fuse to be changed back? [y/n] "

Submitter:  Xavier <fjrg76>
Submitted:  Sat 08 Jul 2017 01:18:52 AM UTC
   
 
Category:  None Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  None Privacy:  Public
Assigned to:  None Originator Name:  Xavier (fjrg76)
Open/Closed:  Open Release:  6.3
Programmer hardware:  Device type: 

Sat 08 Jul 2017 01:18:52 AM UTC, original submission:  

Nothing happens when n is typed in such situation. Just blank lines as long as you type "enter" or any other key. The only way to exit the program is with "Ctrl+C".

I digged into the source code (both 6.2 which is installed in my system, and 6.3) and there is nothing to do when "n" is typed. Something should happen in this situation, so the user knows what's going on. Here is the code snippet, if it worhs:

/* Now check what fuses are against what they should be */
    if (safemodeafter_efuse != safemode_efuse) {
      fuses_updated = 1;
      avrdude_message(MSG_INFO, "%s: safemode: efuse changed! Was %x, and is now %x\n",
              progname, safemode_efuse, safemodeafter_efuse);

      /* Ask user - should we change them */
       if (silentsafe == 0)
            safemode_response = terminal_get_input("Would you like this fuse to be changed back? [y/n] ");
       else
            safemode_response = yes;
       if (tolower((int)(safemode_response[0])) == 'y') { /// THERE IS NO 'ELSE'
             
            /* Enough chit-chat, time to program some fuses and check them */
            if (safemode_writefuse (safemode_efuse, "efuse", pgm, p,
                                    10) == 0) {
                avrdude_message(MSG_INFO, "%s: safemode: and is now rescued\n", progname);
            }
            else {
                avrdude_message(MSG_INFO, "%s: and COULD NOT be changed\n", progname);
                failures++;
            }
       }
    }


Thanks!!

Xavier <fjrg76>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by fjrg76 (Submitted the item)
  • -email is unavailable- added by fjrg76
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-07-08 fjrg76 Carbon-Copy- Added fjrg76

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code