bugGNU roff - Bugs: bug #51588, [PATCH] [hdtbl]...

 
 

bug #51588: [PATCH] [hdtbl] col_rowspan_colors.roff example doesn't follow its own rule

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Thu 27 Jul 2017 02:46:32 AM UTC
   
 
Category:  Macro - others/general Severity:  3 - Normal
Item Group:  Documentation Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.22.4
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 24 Jan 2022 01:19:44 PM UTC, comment #2: 


commit e44909563c634c45e0ebc813e6e6d539a17030ed
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Wed Nov 1 00:00:45 2017 -0400

    col_rowspan_colors.roff: Integer must be odd.

    Also:
    * Remove space at end of lines.
    * Correct use of ".tm" to include a space at the beginning.
    * Add a space between a number and a unit in a comment.

    Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>

    Additionally:

    Add comment documenting use of unsafe macros.

    Signed-off-by: G. Branden Robinson <g.branden.robinson@gmail.com>


G. Branden Robinson <gbranden>
Group administrator
Wed 01 Nov 2017 04:16:24 AM UTC, comment #1: 

Fixed in e44909563c634c45e0ebc813e6e6d539a17030ed.

G. Branden Robinson <gbranden>
Group administrator
Thu 27 Jul 2017 02:46:32 AM UTC, original submission:  


From c8144acacaca4746aded9ead8ee36b70d9d5ffbf Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Thu, 27 Jul 2017 02:42:23 +0000
Subject: [PATCH] src: col_rowspan_colors.roff: variable must be an odd integer

  Also:

  Remove space at end of lines.

  Correct use of ".tm" to include a space at the beginning

  Add a space between a number and an unit.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 contrib/hdtbl/examples/col_rowspan_colors.roff | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/contrib/hdtbl/examples/col_rowspan_colors.roff b/contrib/hdtbl/examples/col_rowspan_colors.roff
index 7f58b918..3c0dae18 100644
--- a/contrib/hdtbl/examples/col_rowspan_colors.roff
+++ b/contrib/hdtbl/examples/col_rowspan_colors.roff
@@ -18,7 +18,7 @@ FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 for more details.

 You should have received a copy of the GNU General Public License
-along with this program. If not, see <http://www.gnu.org/licenses/>.
+along with this program.  If not, see <http://www.gnu.org/licenses/>.
 ..
 .
 .if !d sopath \
@@ -38,9 +38,9 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
 .nr # 0
 .color#
 .if \\n[t*cols\\n[t*#]]/2*2=\\n[t*cols\\n[t*#]] \{ .
-.   tmc \\n(.F:\\n(.c: cols was even (\\n[t*cols\\n[t*#]]),
+.   tmc \\n(.F:\\n(.c: cols was even (\\n[t*cols\\n[t*#]]),
 .   nr t*cols\\n[t*#] +1
-.   tm  increased by one col to \\n[t*cols\\n[t*#]].
+.   tm1 " increased by one col to \\n[t*cols\\n[t*#]].
 .   t*cl \\*[width]
 .   ie "\\*[tal]"r" .nr in\\n[t*#] -\\*[width]\"    recalculate cell widths etc.
 .   el .if "\\*[tal]"c" .nr in\\n[t*#] -\\*[width]/2
@@ -55,7 +55,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
 .   color#
 .   ds html "".TR height=\\nW" ".TD colspan=\\nI bgc=c\\n#"
 .   color#
-.   as html " ".TD rowspan=\\nI bgc=c\\n#"
+.   as html " ".TD rowspan=\\nI bgc=c\\n#"
 .   color#
 .   as html " ".TR height=\\nW" ".TD rowspan=\\nI bgc=c\\n#"
 .   color#
@@ -70,14 +70,14 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
 .PN 8 Indented text before table.
 *** *** ***
 .TBL width=90% border=1n csp=1n cpd=1n bgc=wheat tal=c .TR .TD
-.TBL  border= cols=10 width=1c tal=c csp=0 cpd=0 \"cols must be odd
+.TBL  border= cols=11 width=1c tal=c csp=0 cpd=0 \"cols must be odd
 .CPTN val=b Randomly Colored Table Cells with Colspan/\%Rowspan
 .brt
-.ETB .ETB
+.ETB .ETB
 .PN 15 Text after table.
 .time
 .date
-.\"        466MHz Celeron CPU, 384MB RAM
+.\"        466 MHz Celeron CPU, 384 MB RAM
 .\"        WindowsXP/cygwin groff18.1:         4s
 .\"        WindowsXP/cygwin groff19.2:         7s
 .\"        Suse Linux 9.3 groff19.2:         1s
--
2.13.2


Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Updated the item)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-22 gbranden CategoryNone Macro - others/general
        Item GroupNone Documentation
        Summary[PATCH] src: col_rowspan_colors.roff: variable must be an odd integer [PATCH] [hdtbl] col_rowspan_colors.roff example doesn't follow its own rule
    2018-11-05 gbranden Open/ClosedOpen Closed
        Planned ReleaseNone 1.22.4
    2017-11-01 gbranden StatusIn Progress Fixed
    2017-11-01 gbranden StatusNone In Progress
        Assigned toNone gbranden

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code