buglwIP - A Lightweight TCP/IP stack - Bugs: bug #51606, ip4_reass: Missing hole check when...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51606: ip4_reass: Missing hole check when inserting pbuf in before another one

Submitter:  Ambroz Bizjak <abizjak>
Submitted:  Fri 28 Jul 2017 04:14:00 PM UTC
   
 
Category:  IPv4 Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  goldsimon
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Wed 02 Aug 2017 07:12:26 PM UTC, comment #2: 

Forget comment #1, I missed that lines 459ff only check from the received fragment to the end...

Fixed, thanks for reporting.

And added a unit test :-)

Simon Goldschmidt <goldsimon>
Group administrator
Wed 02 Aug 2017 06:18:25 PM UTC, comment #1: 

Doesn't lines 459 ff do this?

Simon Goldschmidt <goldsimon>
Group administrator
Fri 28 Jul 2017 04:14:00 PM UTC, original submission:  

http://git.savannah.gnu.org/cgit/lwip.git/tree/src/core/ipv4/ip4_frag.c?id=500598658df1d8674b7d25141983cf5452585d9d#n383

Where a pbuf is inserted before another one, there is no check if there is a hole between the new one and the previous one. There should be a check similar to line 437 where the new pbuf is inserted to the end.

Ambroz Bizjak <abizjak>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by abizjak (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-08-02 goldsimon StatusWorks For Me Fixed
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2017-08-02 goldsimon StatusNone Works For Me

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code