lwIP - A Lightweight TCP/IP stack - Bugs: bug #51729, lwip_itoa: fix converting 0
You are not allowed to post comments on this tracker with your current authentication level.
bug #51729: lwip_itoa: fix converting 0
Submitter: | Joel Cunningham <jcunningham> | ||
Submitted: | Fri 11 Aug 2017 03:29:01 PM UTC | ||
Category: | None | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Jump to the original submission
Tue 09 Jan 2018 01:56:50 PM UTC, comment #9: |
David GIRAULT <dgirault> |
Mon 08 Jan 2018 08:39:26 PM UTC, comment #8: OK, fixed by applying your patch David. I had to modify it just a little...
|
Simon Goldschmidt <goldsimon> |
Mon 08 Jan 2018 08:09:20 PM UTC, comment #7:
|
Simon Goldschmidt <goldsimon> |
Mon 08 Jan 2018 03:24:24 PM UTC, comment #6: New version is still buggy. It can write outside provided buffer if buffer isn't large enough:
|
David GIRAULT <dgirault> |
Sat 23 Dec 2017 07:36:01 PM UTC, comment #5: Fixed and added unit tests for lwip_itoa. |
Simon Goldschmidt <goldsimon> |
Sat 23 Dec 2017 07:34:53 PM UTC, comment #4: Right |
Simon Goldschmidt <goldsimon> |
Tue 19 Dec 2017 12:07:24 PM UTC, comment #3: lwip_itoa is still buggy! converting 0 is fixed (the bad way) but the following case still fail:
|
David GIRAULT <dgirault> |
Fri 11 Aug 2017 06:40:36 PM UTC, comment #2: Patch committed in 9844049cb181d296840cf1a0e718bf960ca67ceb |
Joel Cunningham <jcunningham> |
Fri 11 Aug 2017 06:28:39 PM UTC, comment #1: Looks good. |
Simon Goldschmidt <goldsimon> |
Fri 11 Aug 2017 03:29:01 PM UTC, original submission:
Found that 0 can't be converted when passed to lwip_itoa. This was found via shell cmd idxtoname and win32 port. "lo0" should
|
Joel Cunningham <jcunningham> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 13 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-01-08 | goldsimon | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2018-01-08 | goldsimon | Status | Fixed | In Progress | |
Open/Closed | Closed | Open | |||
2017-12-23 | goldsimon | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2017-12-23 | goldsimon | Status | Fixed | In Progress | |
Assigned to | jcunningham | goldsimon | |||
Open/Closed | Closed | Open | |||
2017-12-19 | dgirault | Attached File | - | Added lwip_itoa.patch, #42681 | |
2017-08-11 | jcunningham | Status | None | Fixed | |
Open/Closed | Open | Closed | |||
2017-08-11 | jcunningham | Attached File | - | Added 0001-lwip_itoa-fix-converting-0.patch, #41480 |
Powered by Savane 3.13-3230.
Corresponding source code
Well, since I don't push patch or bugfix on a regular basis, I didn't this weird behavior on this bugtracker. Thanks for advice.
Anyway, thank for applying it before I fix the style and rebase it to latest master.
Regards,
David