lwIP - A Lightweight TCP/IP stack - Bugs: bug #51897, PPP Stats Support in LCP
You are not allowed to post comments on this tracker with your current authentication level.
bug #51897: PPP Stats Support in LCP
Submitter: | G Smith <gsmith> | ||
Submitted: | Wed 30 Aug 2017 04:55:41 PM UTC | ||
Category: | PPP | Severity: | 3 - Normal |
Item Group: | Feature Request | Status: | Wont Fix |
Privacy: | Public | Assigned to: | gradator |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | 2.0.2 |
Jump to the original submission
Wed 10 Jan 2018 09:31:34 PM UTC, comment #7: |
Simon Goldschmidt <goldsimon> |
Wed 10 Jan 2018 08:58:28 PM UTC, comment #6: PPP_LCP_ADAPTIVE isn't supported. This isn't even supported from pppd upstream, I merged the patch from Debian package because it looked interesting at the time.
|
Sylvain Rochet <gradator> |
Mon 08 Jan 2018 08:40:18 PM UTC, comment #5: Sylvain, can you say anything about this? |
Simon Goldschmidt <goldsimon> |
Fri 17 Nov 2017 08:52:06 PM UTC, comment #4: Sylvain, do you have any comments on this? To me it seems like:
|
Simon Goldschmidt <goldsimon> |
Thu 31 Aug 2017 07:00:24 PM UTC, comment #3: Ehrm, it doesn't seem to me that 'link_stats.pkts_in' is ever increased, so this is probably not working anyway? |
Simon Goldschmidt <goldsimon> |
Thu 31 Aug 2017 02:26:56 PM UTC, comment #2: That's true, don't know why I missed that. However, the problem remains that link_stats isn't declared without PPP_STATS_SUPPORT. So is there another variable that can be used to see if there was any traffic previously besides link_stats.pkts_in? |
G Smith <gsmith> |
Thu 31 Aug 2017 01:28:14 AM UTC, comment #1: That won't work because with your change last_pkts_in is always 0. |
Axel Lin <axellin> |
Wed 30 Aug 2017 04:55:41 PM UTC, original submission:
I have recently enabled the PPP_LCP_ADAPTIVE feature to test it out, as I'm having problems with one of the peers responding to echo requests. Anyhow, in lcp.c, around line 2744, the compiler complains that 'link_stats' is undeclared. I think this is because I don' t have PPP_STATS_SUPPORT enabled and the #endif is not encompassing the next few lines as it should.
|
G Smith <gsmith> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-01-10 | gradator | Item Group | Compiler Warning | Feature Request | |
Status | None | Wont Fix | |||
Open/Closed | Open | Closed | |||
2017-11-05 | dziegel | Assigned to | None | gradator |
Powered by Savane 3.13-f8d8.
Corresponding source code
Thanks for resolving this.
All we could do is to clarify which of the options in ppp.h (not ppp_opts.h) are really unsupported (in contrast to "rarely used PPP feature") to prevent false positives like this in the future...