lwIP - A Lightweight TCP/IP stack - Bugs: bug #51908, PPPOS uses PBUF_POOL in transmit...
You are not allowed to post comments on this tracker with your current authentication level.
bug #51908: PPPOS uses PBUF_POOL in transmit pathway
Submitter: | Joel Cunningham <jcunningham> | ||
Submitted: | Thu 31 Aug 2017 07:12:36 PM UTC | ||
Category: | PPP | Severity: | 3 - Normal |
Item Group: | Change Request | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Jump to the original submission
Thu 14 Jun 2018 01:50:32 PM UTC, comment #8: |
Joel Cunningham <jcunningham> |
Thu 14 Jun 2018 01:34:19 PM UTC, comment #7: Yes, I know. And yes, the author has made up a new mechanism to allocate a buffer to encode PPP data. There is absolutely no need for this buffer to be a pbuf. However, using a PBUF_POOL here is better (I think) than using PBUF_RAM because of the smaller allocation overhead.
|
Simon Goldschmidt <goldsimon> |
Thu 14 Jun 2018 01:28:17 PM UTC, comment #6: I think you can still use PBUF_RAM here, we just need to choose a pre-allocated size and maybe introduce a define for it. See pppos_output_append() where it uses PBUF_POOL_BUFSIZE to determine the maximum size
|
Joel Cunningham <jcunningham> |
Wed 13 Jun 2018 07:38:54 AM UTC, comment #5: Thanks for testing, should be fixed. After all, using PBUF_POOL is ok in this very special case as here we know the pbuf is not kept allocated and thus cannot starve rx. |
Simon Goldschmidt <goldsimon> |
Wed 13 Jun 2018 07:06:11 AM UTC, comment #4: I just found PPPoS stop working after below commit:
|
Axel Lin <axellin> |
Tue 12 Jun 2018 08:40:12 AM UTC, comment #3: Done as suggested in comment #2. |
Simon Goldschmidt <goldsimon> |
Fri 17 Nov 2017 08:53:44 PM UTC, comment #2: Sylvain, if you have no objections, I'll just change those into PBUF_RAM.
|
Simon Goldschmidt <goldsimon> |
Thu 31 Aug 2017 07:58:37 PM UTC, comment #1: Places are:
|
Simon Goldschmidt <goldsimon> |
Thu 31 Aug 2017 07:12:36 PM UTC, original submission:
See discussion here: http://lists.nongnu.org/archive/html/lwip-devel/2017-08/msg00150.html
|
Joel Cunningham <jcunningham> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-06-12 | goldsimon | Status | None | Fixed | |
Assigned to | gradator | goldsimon | |||
Open/Closed | Open | Closed | |||
2017-11-05 | dziegel | Assigned to | None | gradator |
Powered by Savane 3.13-3230.
Corresponding source code
Agreed, the short lifetime of the PBUF_POOL won't cause RX starvation
Agreed, I originally brought the issue to the list because it was confusing that we violated our own rule (PBUF_POOL is only for RX) but you've added some comments explaining the situation, so hopefully future devs aren't confused