bugQuilt - Bugs: bug #51977, Latest change in quilt.el makes...

 
 

bug #51977: Latest change in quilt.el makes Emacs barf

Submitter:  None
Submitted:  Sun 10 Sep 2017 01:22:23 PM UTC
   
 
Category:  None Severity:  4 - Important
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  khali
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 02 Nov 2017 01:31:28 PM UTC, comment #3: 

No feedback. Fix committed nevertheless:

http://git.savannah.nongnu.org/cgit/quilt.git/commit/?id=0f2a913751c8e37a190b783decfa933f199b48cd

Please reopen if it did not fix your problem.

Jean Delvare <khali>
Group administrator
Wed 13 Sep 2017 06:36:15 AM UTC, comment #2: 

Please try the attached patch and report.

(file #41791)

Jean Delvare <khali>
Group administrator
Tue 12 Sep 2017 03:00:11 AM UTC, comment #1: 

If it is trivial, maybe you can provide a patch to fix it? ;-)

Me, I don't use emacs and I didn't do lisp since school. All I can do is transmit your report to the author of the faulty commit.

Jean Delvare <khali>
Group administrator
Sun 10 Sep 2017 01:22:23 PM UTC, original submission:  

Hello,

the last patch of quilt.el (http://git.savannah.nongnu.org/cgit/quilt.git/commit/lib/quilt.el?id=059cba7c6fe781d1707f4503e4f09257cc1a24db) causes a lisp error in quilt-short-patchname when quilt-top-patch would return nil, with a rather uncanny message:

Lisp error: (wrong-type-argument stringp nil)
  file-name-nondirectory(nil)
  (let ((p (file-name-nondirectory (quilt-top-patch)))) (if (not p) "none" (let ((p2 (file-name-sans-extension p))) (if (< (length p2) 10) p2 (concat (substring p2 0 8) "..")))))
  quilt-short-patchname()
  (concat " Q:" (quilt-short-patchname))
  (setq quilt-mode-line (concat " Q:" (quilt-short-patchname)))
  quilt-update-modeline()

Could this be fixed? It seems rather trivial.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #41791:  001-fix-no-top-patch.patch added by khali (687B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by khali (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-11-02 khali StatusNeed Info Fixed
        Open/ClosedOpen Closed
    2017-09-13 khali Attached File- Added 001-fix-no-top-patch.patch, #41791
        Severity3 - Normal 4 - Important
        StatusNone Need Info
        Assigned toNone khali

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code