bugGNU roff - Bugs: bug #52333, [PATCH] om.tmac-u: test for...

 
 

bug #52333: [PATCH] om.tmac-u: test for compatibility mode robustly

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Fri 03 Nov 2017 02:23:32 AM UTC
   
 
Category:  Macro mom Severity:  3 - Normal
Item Group:  Incorrect behaviour Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.22.4
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 01 Apr 2023 02:56:21 PM UTC, comment #1: 


commit 4adf51897b2a6976c5977ab8e4ea45441bee71b2
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Fri Nov 10 08:47:56 2017 -0500

    mom: Abort early with diagnostic in compat mode.

    Test compatibility mode register using traditional syntax.

    Rearrange requirement checks to go from general to specific.

    Tested with "groff -C -ww om.tmac-u".

    Fix bug https://savannah.gnu.org/bugs/?52333.

    Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
    Signed-off-by: G. Branden Robinson <g.branden.robinson@gmail.com>


(I neglected to use --author to identify Bjarni when committing this 5+ years ago.)

G. Branden Robinson <gbranden>
Group administrator
Fri 03 Nov 2017 02:23:32 AM UTC, original submission:  


From 62fd1826751cbb2979187ade88fb7a9821584cf8 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Fri, 3 Nov 2017 01:57:14 +0000
Subject: [PATCH] om.tmac-u: Compatibility mode demands either name '(.C' or '.do ...'

  Some tests are rearanged so they will be a valid code and more logical(?).

  Tested with "groff -C -ww om.tmac-u".

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 contrib/mom/om.tmac-u | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/contrib/mom/om.tmac-u b/contrib/mom/om.tmac-u
index c20510e9..2425340a 100644
--- a/contrib/mom/om.tmac-u
+++ b/contrib/mom/om.tmac-u
@@ -46,20 +46,20 @@ extensions, and float management).
 \#
 \# ====================================================================
 \#
+.if \n(.C \
+.   ab [mom]: The groff mom macros do not work in compatibility mode.
+\# Check that GNU troff is being run
+.if !\n[.g]=1 \
+.   ab [mom]: The mom macros require that you be running GNU troff.
+\# Check which version of groff is being run
+.if (\n[.x]\n[.y] < 118) \
+.   ab [mom]: You need GNU troff version 1.18 or higher to run this version of mom.
 \# Mom version
 .ds version 2.2-a
 .if dVERSION \{\
 .   ab [mom]: Version \*[version]
 .\}
 \#
-\# Check which version of groff is being run
-.if (\n[.x]\n[.y] < 118) \
-.   ab [mom]: You need GNU troff version 1.18 or higher to run this version of mom.
-\# Check that GNU troff is being run
-.if !\n[.g]=1 \
-.   ab [mom]: The mom macros require that you be running GNU troff.
-.if \n[.C] \
-.   ab [mom]: The groff mom macros do not work in compatibility mode.
 \# Add supplementary styles
 .sty \n[.fp] UL      \"  Ultra Light
 .sty \n[.fp] ULI     \"  Ultra Light Italic
--
2.14.2


Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bgarrigues (Updated the item)
  • -email is unavailable- added by gbranden (Updated the item)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-04-01 gbranden Planned ReleaseNone 1.22.4
        Summary[PATCH] om.tmac-u: Compatibility mode demands either name '(.C' or '.do ...' [PATCH] om.tmac-u: test for compatibility mode robustly
    2018-07-02 bgarrigues Open/ClosedOpen Closed
    2017-11-10 gbranden SummaryPATCH] om.tmac-u: Compatibility mode demands either name '(.C' or '.do ...' [PATCH] om.tmac-u: Compatibility mode demands either name '(.C' or '.do ...'
    2017-11-10 gbranden StatusIn Progress Fixed
    2017-11-10 gbranden StatusNone In Progress
        Assigned toNone gbranden

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code