lwIP - A Lightweight TCP/IP stack - Bugs: bug #52747, mdns resp: separate the announce...
You are not allowed to post comments on this tracker with your current authentication level.
bug #52747: mdns resp: separate the announce function and add netifapi support for it
Submitter: | Douglas <ourairquality> | ||
Submitted: | Wed 27 Dec 2017 01:31:37 PM UTC | ||
Category: | DNS | Severity: | 3 - Normal |
Item Group: | Change Request | Status: | Fixed |
Privacy: | Public | Assigned to: | None |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Jump to the original submission
Sat 30 Dec 2017 10:03:18 PM UTC, comment #6: |
Douglas <ourairquality> |
Sat 30 Dec 2017 02:14:44 PM UTC, comment #5: Well, not exactly maybe. That would break layering. mdns should work as callback app without tcpip thread support, too... |
Simon Goldschmidt <goldsimon> |
Sat 30 Dec 2017 01:40:43 PM UTC, comment #4:
|
Douglas <ourairquality> |
Sat 30 Dec 2017 01:10:21 PM UTC, comment #3:
|
Simon Goldschmidt <goldsimon> |
Sat 30 Dec 2017 12:52:33 PM UTC, comment #2: A significant part of the change was to stop announcing on calls to mdns_resp_add_netif and mdns_resp_add_service, see "The interface setup functions no longer invokes an announcement."
|
Douglas <ourairquality> |
Sat 30 Dec 2017 11:08:49 AM UTC, comment #1: Applied a modified version of your patch. Thanks! |
Dirk Ziegelmeier <dziegel> |
Wed 27 Dec 2017 01:31:37 PM UTC, original submission:
The mDNS responder uses a lot of stack for a small system. This patch attempts to mitigate this by allowing the announce code paths to run in the tcpip thread where the stack can be provisioned, and removing that burden from all threads that might invoke an announcement.
|
Douglas <ourairquality> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-12-30 | dziegel | Status | None | Fixed | |
Open/Closed | Open | Closed | |||
2017-12-28 | ourairquality | Attached File | - | Added 0001-mdns-resp-separate-the-announce-function-and-add-net.patch, #42745 | |
2017-12-27 | ourairquality | Attached File | - | Added 0001-mdns-resp-separate-the-announce-function-and-add-net.patch, #42735 |
Powered by Savane 3.13-d3ae.
Corresponding source code
It seems to work well using 'tcpip_callback()', and with a 'pending' flag it can even avoid some redundant announcements.
Could 'tcpip_callback()' be extended to work in the NO_SYS case too, in a similar way that the timers are currently checked by calling 'sys_check_timeouts()' in the event loop?
These callback might be useful even for NO_SYS as this might defer a heavy operation and this might help with latency for some operations and help reduce the peak resource usage. In any case it might be a small burden for NO_SYS that helps keep the large code cleaner.