buglwIP - A Lightweight TCP/IP stack - Bugs: bug #53119, pppol2tp:NS count is uncorrect for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #53119: pppol2tp:NS count is uncorrect for hello message

Submitter:  kaiqin lin <lin704932121>
Submitted:  Sun 11 Feb 2018 06:10:50 AM UTC
   
 
Category:  PPP Severity:  3 - Normal
Item Group:  Faulty Behaviour Status:  Fixed
Privacy:  Public Assigned to:  gradator
Open/Closed:  Closed Planned Release:  None
lwIP version:  git head

Jump to the original submission

Fri 15 Jun 2018 12:18:51 PM UTC, comment #6: 

Fixed in commit b9fe13c10523.

Sylvain Rochet <gradator>
Group Member
Thu 14 Jun 2018 01:00:03 PM UTC, comment #5: 

Thanks for your response. No, I wouldn't have applied this patch. I'm far too unexperienced with the ppp sources at that level ;-)

Simon Goldschmidt <goldsimon>
Group administrator
Thu 14 Jun 2018 12:14:40 PM UTC, comment #4: 

I am currently looking into it and will come up with a solution today or tomorrow (promised!).

Please don't apply the attached patch, it is obviously not the proper way to fix that.

Sylvain

Sylvain Rochet <gradator>
Group Member
Tue 12 Jun 2018 08:31:14 AM UTC, comment #3: 

Sylvain, do you have any input on this?

Simon Goldschmidt <goldsimon>
Group administrator
Wed 23 May 2018 08:01:13 PM UTC, comment #2: 

Sylvain, do you have any input on this?

Simon Goldschmidt <goldsimon>
Group administrator
Wed 14 Feb 2018 08:06:50 PM UTC, comment #1: 


> change code as fllows in pppol2tp_dispatch_control_packet() function


Could you attach a patch that applies cleanly against a given version or commit?

Simon Goldschmidt <goldsimon>
Group administrator
Sun 11 Feb 2018 06:10:50 AM UTC, original submission:  

I use xl2tpd as server in ubuntu, but l2tp is disconnected after a while. What I found is that the NS count is uncorrect for hello message. To fix the bug, change code as fllows in pppol2tp_dispatch_control_packet() function:


  switch(messagetype) {
    /* Start Control Connection Reply */
    case PPPOL2TP_MESSAGETYPE_SCCRP:
      .....
      break;
    /* Incoming Call Reply */
    case PPPOL2TP_MESSAGETYPE_ICRP:
      .....
      break;
    /* Unhandled packet, send ZLB ACK */
    default:
      goto send_zlb;
  }
  return;

------------>

  switch(messagetype) {
    /* Start Control Connection Reply */
    case PPPOL2TP_MESSAGETYPE_SCCRP:
      .....
      break;
    /* Incoming Call Reply */
    case PPPOL2TP_MESSAGETYPE_ICRP:
      .....
      break;
    case PPPOL2TP_MESSAGETYPE_HELLO:
      pppol2tp_send_zlb(l2tp, l2tp->our_ns+1);
      break;
    /* Unhandled packet, send ZLB ACK */
    default:
      goto send_zlb;
  }
  return;


kaiqin lin <lin704932121>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #43435:  0001-fix-uncorrect-NS-count-for-hello-message.patch added by lin704932121 (790B - application/octet-stream - I attached patch file to fix the bug.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gradator (Posted a comment)
  • -email is unavailable- added by goldsimon
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by lin704932121 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-06-15 gradator StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2018-06-14 gradator CategoryNone PPP
        StatusNone In Progress
        Assigned toNone gradator
    2018-06-12 goldsimon Carbon-Copy- Added -email is unavailable-
    2018-03-02 lin704932121 Attached File- Added 0001-fix-uncorrect-NS-count-for-hello-message.patch, #43435

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code