bugGNU roff - Bugs: bug #53796, [PATCH] man pages: Add italic...

 
 

bug #53796: [PATCH] man pages: Add italic correction before '\c'

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Mon 30 Apr 2018 09:36:25 PM UTC
   
 
Category:  General Severity:  3 - Normal
Item Group:  Lint Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.22.4
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 05 Mar 2022 10:31:33 PM UTC, comment #3: 


commit 7823c1ca9e095f0e9bb1b6e07d979aae7695514c
Author: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date:   Mon Apr 30 21:30:32 2018 +0000

    man pages: Add italic correction before '\c'.

    The italic correction '\/' in the macros 'I', '[BR]I', and 'I[BR]' is
    ignored if it is applied after a '\c' escape in an argument.

    Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>

    "\c works on the output level. Anything after this escape on the same
    line is ignored except \R, which works as usual." (_The GNU Troff
    Manual_, section 5.14, "Line Control")

    Manually restore the italic correction where applicable.

    And even where it's not; the next thing output after the italic
    correction in the chem.1 and groff_man.1 cases is a space, which does
    not receive an italic correction.  But it's harmless, seems better to
    have it for pedagogical (or cargo-cult) reasons, and is more robust
    against future changes that may put a glyph where the space had been.

    Signed-off-by: G. Branden Robinson <g.branden.robinson@gmail.com>


G. Branden Robinson <gbranden>
Group administrator
Mon 18 Jun 2018 07:21:31 AM UTC, comment #2: 

Fixed in 7823c1ca9e095f0e9bb1b6e07d979aae7695514c.

G. Branden Robinson <gbranden>
Group administrator
Mon 18 Jun 2018 06:24:13 AM UTC, comment #1: 

Just as a comment, I'm A/Bing the impact of this with groffer/evince and the difference is very, very subtle.

And in some of the cases you patched, it has no effect, probably because the following glyph is a space.

Looking at the ditroff output, we can see that this is true for chem.1 and groff_man.1.


G. Branden Robinson <gbranden>
Group administrator
Mon 30 Apr 2018 09:36:25 PM UTC, original submission:  

From cc58166a76c5921d30981aa91a60f0cc6c040e4f Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Mon, 30 Apr 2018 21:30:32 +0000
Subject: [PATCH] man pages: Add italic correction before '\c'

  The italic correction '\/' in the macros 'I', '[BR]I', and 'I[BR] is
removed if it is applied after a '\c' escape in an argument.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 contrib/chem/chem.1.man     |  4 ++--
 contrib/mom/groff_mom.7.man |  2 +-
 man/groff_font.5.man        | 10 +++++-----
 src/roff/groff/groff.1.man  |  2 +-
 tmac/groff_man.7.man        |  2 +-
 tmac/groff_me.7.man         |  2 +-
 6 files changed, 11 insertions(+), 11 deletions(-)

  The patch is in the attachment.

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-03-05 gbranden CategoryNone General
        Item GroupFeature change Lint
    2018-06-18 gbranden StatusIn Progress Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.22.4
    2018-06-18 gbranden StatusNone In Progress
        Assigned toNone gbranden
    2018-04-30 bjarniig Attached File- Added 0001-man-pages-Add-italic-correction-before-c.txt, #44064

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code