buglwIP - A Lightweight TCP/IP stack - Bugs: bug #54327, V2.1.0rc1 pbuf.c misses stdint.h...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #54327: V2.1.0rc1 pbuf.c misses stdint.h include

Submitter:  Ole Christensen <ole_c>
Submitted:  Tue 17 Jul 2018 06:40:01 PM UTC
   
 
Category:  pbufs Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Planned Release:  None
lwIP version:  Other

Wed 18 Jul 2018 05:28:38 AM UTC, comment #5: 

Re comment #2:
Yes, that commit is far too big. It seems to contain style changes of Dirks clang-format tests. It would be better to revert this and apply a fix for this issue only to get a clean history.

Re comment #4:
No, lwIP still uses 'u16_t', not 'uint16_t'. If stdint.h is available, its types are used to declare our own types. Not the other way round.

However, it might be an idea for the future to drop our own types and use stdint.h types only. The targets that don't have stdint.h could still define the types like they do today...

Simon Goldschmidt <goldsimon>
Group administrator
Wed 18 Jul 2018 05:16:47 AM UTC, comment #4: 

I think use uint16_t should also work.

see src/include/lwip/arch.h:

/** Define this to 1 in arch/cc.h of your port if your compiler does not provide

  • the stdint.h header. You need to typedef the generic types listed in
  • lwip/arch.h yourself in this case (u8_t, u16_t...).

 */
#ifndef LWIP_NO_STDINT_H
#define LWIP_NO_STDINT_H 0
#endif

Axel Lin <axellin>
Group Member
Wed 18 Jul 2018 04:21:00 AM UTC, comment #3: 

uint16_t --> u16_t :-)

Ole Christensen <ole_c>
Tue 17 Jul 2018 10:13:15 PM UTC, comment #2: 

Hi Dirk,

I'm wondering how the commit 4e74421dac26 fixes this issue?
http://git.savannah.gnu.org/cgit/lwip.git/commit/?id=4e74421dac26f2646200b96d5f493982da522ef1

The diff looks so big, and the changes looks not related to this issue.

Axel Lin <axellin>
Group Member
Tue 17 Jul 2018 07:08:20 PM UTC, comment #1: 

Fixed, thanks for reporting!!

Dirk Ziegelmeier <dziegel>
Group administrator
Tue 17 Jul 2018 06:40:01 PM UTC, original submission:  

Looks like my setup is somehow different from others, but pbuf.c uses uint16_t and should thus include stdint.h imho.

Thanks, Ole

Ole Christensen <ole_c>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by axellin (Posted a comment)
  • -email is unavailable- added by dziegel (Posted a comment)
  • -email is unavailable- added by ole_c (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-07-17 dziegel StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code