lwIP - A Lightweight TCP/IP stack - Bugs: bug #54327, V2.1.0rc1 pbuf.c misses stdint.h...
You are not allowed to post comments on this tracker with your current authentication level.
bug #54327: V2.1.0rc1 pbuf.c misses stdint.h include
Submitter: | Ole Christensen <ole_c> | ||
Submitted: | Tue 17 Jul 2018 06:40:01 PM UTC | ||
Category: | pbufs | Severity: | 3 - Normal |
Item Group: | None | Status: | Fixed |
Privacy: | Public | Assigned to: | None |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | Other |
Wed 18 Jul 2018 05:28:38 AM UTC, comment #5: |
Simon Goldschmidt <goldsimon> |
Wed 18 Jul 2018 05:16:47 AM UTC, comment #4: I think use uint16_t should also work.
*/
|
Axel Lin <axellin> |
Wed 18 Jul 2018 04:21:00 AM UTC, comment #3: uint16_t --> u16_t :-) |
Ole Christensen <ole_c> |
Tue 17 Jul 2018 10:13:15 PM UTC, comment #2: Hi Dirk,
|
Axel Lin <axellin> |
Tue 17 Jul 2018 07:08:20 PM UTC, comment #1: Fixed, thanks for reporting!! |
Dirk Ziegelmeier <dziegel> |
Tue 17 Jul 2018 06:40:01 PM UTC, original submission:
Looks like my setup is somehow different from others, but pbuf.c uses uint16_t and should thus include stdint.h imho.
|
Ole Christensen <ole_c> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 2 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-07-17 | dziegel | Status | None | Fixed | |
Open/Closed | Open | Closed |
Powered by Savane 3.13-f8d8.
Corresponding source code
Re comment #2:
Yes, that commit is far too big. It seems to contain style changes of Dirks clang-format tests. It would be better to revert this and apply a fix for this issue only to get a clean history.
Re comment #4:
No, lwIP still uses 'u16_t', not 'uint16_t'. If stdint.h is available, its types are used to declare our own types. Not the other way round.
However, it might be an idea for the future to drop our own types and use stdint.h types only. The targets that don't have stdint.h could still define the types like they do today...