bugThe FreeType Project - Bugs: bug #57541, CFF2: Commit...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #57541: CFF2: Commit 4270e9f3243079bb90b6af618ed4d4fd31266412 breaks space glyphs

Submitter:  Nikolaus Waxweiler <morksig>
Submitted:  Sun 05 Jan 2020 04:42:29 PM UTC
   
 
Severity:  4 - Important Item Group:  None
Status:  Fixed Privacy:  Public
Assigned to:  wl Open/Closed:  Closed
Planned Release:  2.10.2

Tue 25 Feb 2020 10:15:52 AM UTC, comment #4: 

Thanks, pushed!

Werner LEMBERG <wl>
Group administrator
Tue 25 Feb 2020 09:21:46 AM UTC, comment #3: 

Confirming that the attached patch fixes the space insertion issue.

Dominik Röttsches <drott>
Tue 25 Feb 2020 09:16:33 AM UTC, comment #2: 

Patch looks reasonable, thanks!  Please drop a note as soon as I should commit it.

Werner LEMBERG <wl>
Group administrator
Tue 25 Feb 2020 09:10:17 AM UTC, comment #1: 

Experimental patch attached, I'll try to verify this one.


(file #48495)

Dominik Röttsches <drott>
Sun 05 Jan 2020 04:42:29 PM UTC, original submission:  

A measure to fix undefined behavior and an edge-case (I presume) makes all space glyphs in CFF2 fonts zero-width: https://lists.nongnu.org/archive/html/freetype-devel/2019-12/msg00000.html

The if-block returns early if `charstring_base == charstring_len == 0`, even when that's valid for space glyphs like U+0020. Not sure how to handle this in a way that the fuzzer/sanitizer approves of.

Nikolaus Waxweiler <morksig>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by wl (Posted a comment)
  • -email is unavailable- added by drott (Updated the item)
  • -email is unavailable- added by morksig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-02-25 wl StatusReady For Test Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 2.10.2
    2020-02-25 wl StatusNone Ready For Test
        Assigned toNone wl
    2020-02-25 drott Attached File- Added 0001-Experimental-fix-for-CFF-space-glyph-regression-5754.patch, #48495

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code