lwIP - A Lightweight TCP/IP stack - Bugs: bug #58473, Trailing dot in hostname results...
You are not allowed to post comments on this tracker with your current authentication level.
bug #58473: Trailing dot in hostname results in extraneous label (and corrupt packet)
Submitter: | Mate Varga <matevarga> | ||
Submitted: | Sun 31 May 2020 09:31:13 PM UTC | ||
Category: | DNS | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | None |
Privacy: | Public | Assigned to: | None |
Open/Closed: | Open | Planned Release: | None |
lwIP version: | git head |
Jump to the original submission
Fri 19 Jun 2020 11:13:40 AM UTC, comment #8: |
Erik Ekman <yarrick> |
Fri 19 Jun 2020 11:12:48 AM UTC, comment #7: By disabling LWIP_RAND_FOR_FUZZ I got some of them to fail:
|
Erik Ekman <yarrick> |
Fri 19 Jun 2020 10:14:47 AM UTC, comment #6: If we just do this change, lookups of the same domain with and without a trailing dot will not share a hostlist entry but trigger a second lookup as I understand it. Removing the dot before checking the list of cached entries seems better to me.
|
Erik Ekman <yarrick> |
Wed 17 Jun 2020 07:56:48 PM UTC, comment #5: I guess it's correct and does no harm, but Erik, do you have any more comments on this? |
Simon Goldschmidt <goldsimon> |
Wed 17 Jun 2020 06:24:30 AM UTC, comment #4: Any opinions? The bug is quite clear I think and the patch is extremely simple. |
Mate Varga <matevarga> |
Mon 08 Jun 2020 09:17:13 AM UTC, comment #3: And yes, my original comment was incorrect. It should have been like (see the extra zero-markers):
|
Mate Varga <matevarga> |
Mon 08 Jun 2020 08:55:05 AM UTC, comment #2: Yes, there needs to be a zero-marker, that's fine. But the current code adds two zero-markers if the name ends with a dot.
|
Mate Varga <matevarga> |
Sun 07 Jun 2020 01:50:40 PM UTC, comment #1: There should always be a zero-marker at the end of the name, and it is added at line 827:
|
Erik Ekman <yarrick> |
Sun 31 May 2020 09:31:13 PM UTC, original submission:
Expected behavior:
|
Mate Varga <matevarga> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follows 1 latest change.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2020-05-31 | matevarga | Attached File | - | Added 0001-Does-not-add-an-empty-label-when-encountering-traili.patch, #49191 |
Powered by Savane 3.13-758e.
Corresponding source code
Oops - wrong bug, disregard comment #7.