bugManeage - Bugs: bug #58917, A host gcc plus an absence of...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #58917: A host gcc plus an absence of gfortran should fail quickly

Submitter:  Boud Roukema <boud>
Submitted:  Sat 08 Aug 2020 04:05:39 PM UTC
   
 
Category:  Software Severity:  3 - Normal
Item Group:  Enhancement Status:  Fixed
Privacy:  Public Assigned to:  boud
Open/Closed:  Closed

Sat 08 Aug 2020 05:56:31 PM UTC, comment #1: 

Thanks a lot Boud, good point! It has been merged into Maneage as Commit d3739931e

I just set the definition of this variable in 'configure.sh' to avoid complicating the very high-level 'project' script ;-). Also, I put the full gfortran check inside an 'if' such that they are only done if 'need_gfortran=0'. Because when a project doesn't need 'gfortran', it is just confusing for the users to see this warning!

I just defined task #15745 to hopefully automate this process and not require project authors to worry about needing gfortran (or any other special compiler).

Mohammad Akhlaghi <makhlaghi>
Group administrator
Sat 08 Aug 2020 04:05:39 PM UTC, original submission:  

I'm filing this as a usability bug. :)

To quote from commit f90dcea:


Until this commit, in the case of (i) a project that is known to
need gfortran, and (ii) a user who enables the '--host-cc'
option, and (iii) a host system with gcc but without gfortran,
the './project configure' script gives a big warning about the
need for gfortran and the fact that it is missing, and waits for
5 seconds, but it continues anyway. This means that a lot of time
and cpu cycles are wasted compiling non-fortran software that are
unusable. In an automated test, or in the case of a user who goes
away for coffee for 10-20 minutes or a few hours, this is a
waste.

With this commit, 'project' and
'reproduce/software/shell/configure.sh' are modified so that if
'need_gfortran' is set to 1 in the 'project' file, along with
other environment variables, then the configure stage will halt
immediately if --host-cc is requested and gfortran is not
found. This immediate failure is more likely to be what the user
will expect than a late failure.


https://codeberg.org/boud/maneage_dev/commit/f90dcea57e895c48c8ba56941a22bbdc92b14d32

Possible improvements would be to modify the warning to be a bit more tolerant towards non-gcc people, e.g. clang people (do they have flang?). :)

The need_gfortran flag is set to off in this commit.

Boud Roukema <boud>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Posted a comment)
  • -email is unavailable- added by boud (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-08-08 makhlaghi CategoryNone Software
        Item GroupNone Enhancement
        StatusNone Fixed
        Assigned toNone boud
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code