Maneage - Bugs: bug #60376, metastore is not installed by...
You are not allowed to post comments on this tracker with your current authentication level.
bug #60376: metastore is not installed by default
Submitter: | Boud Roukema <boud> | ||
Submitted: | Sun 11 Apr 2021 09:17:33 PM UTC | ||
Category: | None | Severity: | 3 - Normal |
Item Group: | None | Status: | None |
Privacy: | Public | Assigned to: | None |
Open/Closed: | Open |
Sun 11 Apr 2021 09:31:13 PM UTC, comment #1: |
Boud Roukema <boud>![]() |
Sun 11 Apr 2021 09:17:33 PM UTC, original submission:
BUG: In commit 20b6273 of maneage (and many earlier versions), the claim in README-hacking.md that metastore hooks are automatically installed in .git/hooks/ appears to be incorrect from practical experience (in several different maneage installs), and the code in basic.mk appears to explain this.
DETAILS:
Since basic.mk is run from the top directory, current_dir , and since gbuild changes to a temporary build directory, it seems likely that at line 1106, the shell is in the temporary build directory, not in .git/ .
This would cause a failure to install the two hooks, but no warning message is provided to the user.
SUGGESTED FIX (not tested):
Either shift cd $$current_dir upwards, to be located between lines 1105 and 1106, or modify README-hacking.md to state that installation of metastore hooks is opt-in, not opt-out.
COMMENT:
|
Boud Roukema <boud>![]() |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Just to clarify:
The bug at 1106 is that the shell is in the temporary build directory, not the top directory where .git/ is typically located.
So if [ -d .git ]; yields false - the directory .git doesn't exist in the temporary build directory.