bugSimulavr: an AVR simulator - Bugs: bug #65950, Don't install headers with generic...

 
 

bug #65950: Don't install headers with generic names into top-level include directory

Submitter:  Ryan Carsten Schmidt <ryandesign>
Submitted:  Wed 03 Jul 2024 10:55:13 PM UTC
   
 
Category:  None Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
Component Version:  * simulavr
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Wed 03 Jul 2024 11:28:52 PM UTC, comment #2: 

I used this patch to fix it.

(file #56224)

Ryan Carsten Schmidt <ryandesign>
Wed 03 Jul 2024 11:09:44 PM UTC, comment #1: 

1.0.0 already did this, so this is a regression in 1.1.0.

Ryan Carsten Schmidt <ryandesign>
Wed 03 Jul 2024 10:55:13 PM UTC, original submission:  

1.1.0 installs a bunch of headers into the top-level include directory that have very generic names, such as application.h, config.h, decoder.h, hardware.h, helper.h, memory.h, net.h, types.h. It is quite possible for some other project to fail to build because it inadvertently includes one of your headers instead of its own, if the order of its -I flags is not correct (which is a very common mistake). Please either move all of your headers into a subdirectory named after your project (e.g. simulavr/config.h) or prefix the header names with your project name (e.g. simulavr-config.h).

Ryan Carsten Schmidt <ryandesign>

 

Attached Files

Attached Files
file #56224:  include.patch added by ryandesign (1.1KiB - application/octet-stream)

(Note: upload size limit is set to 4.0MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by ryandesign (Submitted the item)
  •  

    Votes

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    History

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-07-03 ryandesign Attached File- Added include.patch, #56224

    Back to the top

    Powered by Savane 3.16-ed84.
    Corresponding source code