buglwIP - A Lightweight TCP/IP stack - Bugs: bug #9191, Compiler problem with #define's

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #9191: Compiler problem with #define's

Submitted by:  None
Submitted on:  Wed 02 Jun 2004 03:53:58 PM UTC  
 
Category:  IPv4 Severity:  3 - Normal
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Planned Release:  None
lwIP version:  None

Thu 24 May 2007 04:38:59 AM UTC, comment #1: 

The original (anonymous) poster should read the NC308 compiler manual.

In there it states that by default the compiler blatantly disobeys ANSI, and if ANSI operation is required the compiler flag "-fETI" is required. Quoting from the manual:

Function: Extends char type or signed char type data to int type data to perform operation (extension as per ANSI rules).

Supplement: In ANSI standards, the char-type or singed char-type data is always extended into the int type when evaluated. This extension is provided to prevent a problem in char-type arithmetic operations, e.g., c1 = c2 * 2 / c3; that the char type overflows in the middle of operation, and that the result takes on an unexpected value.

And in the case of the original "GETSHORT()" macro, the operation "s = *cp++ << 8" results in an explicit load of "s" with ZERO.

This is broken default compiler operation, but they do provide and document a fix.

If anyone knows who "Anonymous" is, please forward this information back to them.

Tom Evans <tom_evans>
Wed 02 Jun 2004 03:53:58 PM UTC, original submission:  

This is most likely complier bugs. But since these problems exist in quite many mcu compilers it is probably a good thing to make it clearer to the compiler what we want it to do.

in ip.h line 143

In the original macro there is no explcit cast to u16_t for the ttl argument. When using the NC30 compiler for the M16 mcu this results in that (ttl)<<8 -> 0. Is _ttl_proto guaranteed to be zero before the macro is called?

#define IPH_TTL_SET(hdr, ttl) (hdr)->_ttl_proto = (htons(IPH_PROTO(hdr) | (((u16_t)ttl) << 8)))

in ppp.h: line 182

four macros, GETSHORT, PUTSHORT, GETLONG, PUTLONG. They look like this:

#define GETSHORT(s, cp) { \
    (s) = *(cp)++ << 8; \
    (s) |= *(cp)++; \
}

The NC30 compiler *(cp++ << 8). This can be rewritten to avoid using these operator priorities.
#define GETSHORT(s, cp) { \
    (s) = *(cp); (cp)++; (s) << 8; \
    (s) |= *(cp); (cp)++;\
}

regards
Bjorn (bjorn_sundman@yahoo.se)

Anonymous

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by tom_evans (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2006-10-25 christiaans StatusNone => Fixed
        Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.5