mldonkey, a multi-networks file-sharing client - Bugs: bug #15506, Invalid encoding in announce URL
You are not allowed to post comments on this tracker with your current authentication level.
bug #15506: Invalid encoding in announce URL
Submitter: | Bojidar Alexandrov <balexandrov> | ||
Submitted: | Sun 22 Jan 2006 06:08:42 PM UTC | ||
Votes: | 150 | ||
Category: | Bittorrent-Plugin | Severity: | 3 - Normal |
Item Group: | Program malfunction | Status: | None |
Assigned to: | None | Open/Closed: | Closed |
Release: | 2.7.2 | Release: | 2.7.2 |
Operating System: | FreeBSD | Binaries Origin: | CVS / Self compiled |
CPU type: | Intel x86 |
Sat 25 Feb 2006 04:35:24 PM UTC, comment #4: |
darkfader |
Mon 20 Feb 2006 12:55:51 PM UTC, comment #3: This fix works for me :) |
Bojidar Alexandrov <balexandrov> |
Mon 20 Feb 2006 03:34:04 AM UTC, comment #2: I think the actual problem should be solved in the Url class. It should check if the URL already contains "?" plus some parameters and act accordingly.
|
darkfader |
Sun 22 Jan 2006 08:03:18 PM UTC, comment #1: If force_client_ip is false, it does not send IP but the error appears with next parameter like this
|
Bojidar Alexandrov <balexandrov> |
Sun 22 Jan 2006 06:08:42 PM UTC, original submission:
I have problem with one of the biggest trackers in our country (Bulgaria).
|
Bojidar Alexandrov <balexandrov> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 150 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2006-02-21 | spiralvoice | Reassign Item | From group mldonkey, a multi-networks file-sharing client, bugs tracker | To group mldonkey, a multi-networks file-sharing client, patch tracker | |
2006-02-20 | balexandrov | Carbon-Copy | - | Added balexandrov | |
2006-02-20 | darkfader | Carbon-Copy | - | Added darkfader |
Powered by Savane 3.13-bb6a.
Corresponding source code
* mldonkey/src/utils/lib/url.ml 19 Aug 2004 07:56:55 -0000 1.5
--- mldonkey/src/utils/lib/url.ml 25 Feb 2006 16:33:50 -0000
*************
* 161,167 **
if args = [] then s else
let res = Buffer.create 256 in
Buffer.add_string res s;
! Buffer.add_char res '?';
let rec manage_args = function
| [] -> assert false
| [a, ""] ->
--- 161,167 ----
if args = [] then s else
let res = Buffer.create 256 in
Buffer.add_string res s;
! Buffer.add_char res (if String.contains s '?' then '&' else '?');
let rec manage_args = function
| [] -> assert false
| [a, ""] ->
*************