bugmldonkey, a multi-networks file-sharing client - Bugs: bug #17063, Infinite recursion in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #17063: Infinite recursion in commonHasher_c.c:tiger_tree_fd() when file size is less than 1024 bytes

Submitted by:  James Oakley <jfunk>
Submitted on:  Sat 08 Jul 2006 02:19:32 PM UTC  
 
Category:  Core Severity:  3 - Normal
Item Group:  Segmentation Fault Status:  Works For Me
Assigned to:  None Open/Closed:  Closed
Release:  2.7.7/CVS Release:  2.7.7
Operating System:  Linux Binaries Origin:  CVS / Self compiled
CPU type:  Intel x86

Tue 07 Nov 2006 09:20:42 PM UTC, comment #3: 

Please re-compile MLDonkey without using Suses Ocaml packages, they are known to be really buggy:

./configure --enable-force-ocaml

spiralvoice <spiralvoice>
Project Administrator
Sun 16 Jul 2006 11:21:48 PM UTC, comment #2: 

I tried 2.7.6 and it had the same problem, then 2.7.5, and that seems to be ok so far.

James Oakley <jfunk>
Sat 08 Jul 2006 02:36:56 PM UTC, comment #1: 

I just realised that I misreported this bug. I moved the small file out, and it's happened to another file. I moved that one out, and it's still happening:

#0  0x083241af in tiger_tree_fd (fd=85, len=1048576, pos=0, block_size=0, digest=0xb484f0bc "") at src/daemon/common/commonHasher_c.c:89
#1  0x08324204 in tiger_tree_fd (fd=85, len=1048576, pos=0, block_size=0, digest=0xb484f13c "") at src/daemon/common/commonHasher_c.c:118
#2  0x08324204 in tiger_tree_fd (fd=85, len=1048576, pos=0, block_size=0, digest=0xb484f1bc "") at src/daemon/common/commonHasher_c.c:118
#3  0x08324204 in tiger_tree_fd (fd=85, len=1048576, pos=0, block_size=0, digest=0xb484f23c "") at src/daemon/common/commonHasher_c.c:118

So, it has nothing to do with the small file and clearly I need some coffee because I should have realised that before (block_size set to 0, not the size of the file).

James Oakley <jfunk>
Sat 08 Jul 2006 02:19:32 PM UTC, original submission:  

On startup I get a segfault if a file smaller than 1024 bytes is shared. Here's part of the bt:

#0  0x083241af in tiger_tree_fd (fd=87, len=962, pos=0, block_size=0, digest=0xb47d10bc "") at src/daemon/common/commonHasher_c.c:89
#1  0x08324204 in tiger_tree_fd (fd=87, len=962, pos=0, block_size=0, digest=0xb47d113c "") at src/daemon/common/commonHasher_c.c:118
#2  0x08324204 in tiger_tree_fd (fd=87, len=962, pos=0, block_size=0, digest=0xb47d11bc "") at src/daemon/common/commonHasher_c.c:118
#3  0x08324204 in tiger_tree_fd (fd=87, len=962, pos=0, block_size=0, digest=0xb47d123c "") at src/daemon/common/commonHasher_c.c:118
#4  0x08324204 in tiger_tree_fd (fd=87, len=962, pos=0, block_size=0, digest=0xb47d12bc "") at src/daemon/common/commonHasher_c.c:118
#5  0x08324204 in tiger_tree_fd (fd=87, len=962, pos=0, block_size=0, digest=0xb47d133c "") at src/daemon/common/commonHasher_c.c:118
#6  0x08324204 in tiger_tree_fd (fd=87, len=962, pos=0, block_size=0, digest=0xb47d13bc "") at src/daemon/common/commonHasher_c.c:118

This goes on indefinitely until the segfault. Looking at the code, it appears that you're not handling the case when 'block_size' < BLOCK_SIZE.

James Oakley <jfunk>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-11-19 spiralvoice StatusNeed Info => Works For Me
    Open/ClosedOpen => Closed
2006-11-07 spiralvoice StatusNone => Need Info

Back to the top


Powered by Savane 3.5