buglwIP - A Lightweight TCP/IP stack - Bugs: bug #2717, mem_realloc() does not check for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #2717: mem_realloc() does not check for alignment of newsize

Submitter:  michael tesch <tesch>
Submitted:  Tue 04 Mar 2003 06:50:45 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  Crash Error Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Planned Release:  None
lwIP version:  None

Mon 19 Jun 2006 07:52:03 AM UTC, comment #3: 

Returning actual allocation size isn't of much use, at least I think so. As a caller you want at least n bytes and if it's a little more because of alignment than that's fine with me...

Can I close this?

Christiaan Simons <christiaans>
Group Member
Fri 28 Mar 2003 02:42:44 PM UTC, comment #2: 

Patch applied, so essentially fixed.  I just wondered if we should feed the adjusted size back to the caller so they know how much they have actually been given?

Kieran Mansley <kieranm>
Group Member
Thu 20 Mar 2003 10:21:01 PM UTC, comment #1: 

this is the fix.

michael tesch <tesch>
Tue 04 Mar 2003 06:50:45 PM UTC, original submission:  

on machines which require alignment, unaligned 'newsize' will cause a crash.  simply needs to be rounded up.

michael tesch <tesch>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #357:  realloc_align.patch added by tesch (740B - application/octet-stream - patch to fix this bug: copied re-alignment code from mem_malloc())

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 2 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-06-20 christiaans Open/ClosedOpen Closed
2003-03-28 kieranm StatusNone None

Back to the top

Powered by Savane 3.13-d3ae.
Corresponding source code