lwIP - A Lightweight TCP/IP stack - Bugs: bug #28945, Simplify the use of tcp_accepted
You are not allowed to post comments on this tracker with your current authentication level.
bug #28945: Simplify the use of tcp_accepted
| Submitter: | Simon Goldschmidt <goldsimon> | ||
| Submitted: | Sat 20 Feb 2010 05:22:21 PM UTC | ||
| Category: | None | Severity: | 3 - Normal |
| Item Group: | Feature Request | Status: | Fixed |
| Privacy: | Public | Assigned to: | goldsimon |
| Open/Closed: | Closed | Planned Release: | None |
| lwIP version: | CVS Head | ||
|
Sat 06 Mar 2010 12:07:19 PM UTC, comment #3: |
Simon Goldschmidt <goldsimon> |
|
Mon 22 Feb 2010 12:47:26 PM UTC, comment #2: OK, the solution might not be the best, but I still think the current implementation could be improved: most people might try to call tcp_accepted() on the connection-pcb passed to the accept callback. I'll add an assert (state == LISTEN) for now. |
Simon Goldschmidt <goldsimon> |
|
Mon 22 Feb 2010 11:38:55 AM UTC, comment #1: I'd like to give this some thought. I'm not convinced that this is the right change to make. |
Kieran Mansley <kieranm> |
|
Sat 20 Feb 2010 05:22:21 PM UTC, original submission:
Currently, using tcp_accepted() is hard to use: it has to be called with the listen-pcb as argument. However, since that listen-pcb is not available in the accept-callback, it has to be set as callback-arg to the listen-pcb when setting it up.
|
Simon Goldschmidt <goldsimon> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
| Date | Changed by | Updated Field | Previous Value | => | Replaced by |
|---|---|---|---|---|---|
| 2010-03-06 | goldsimon | Status | None | Fixed | |
| Assigned to | None | goldsimon | |||
| Open/Closed | Open | Closed |

Fixed by letting tcp_accepted() assert for pcb->state == LISTEN