bugmldonkey, a multi-networks file-sharing client - Bugs: bug #6956, EDK: Use one UDP port per search

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #6956: EDK: Use one UDP port per search

Submitted by:  None
Submitted on:  Tue 23 Dec 2003 06:04:56 AM UTC  
 
Category:  Core Severity:  4 - Important
Item Group:  Program malfunction Status:  None
Assigned to:  None Open/Closed:  Closed
Release:  Release:  2.5.30.15
Operating System:  Linux Binaries Origin:  CVS / Self compiled
CPU type:  None

( Jump to the original submission)

Tue 09 May 2006 05:37:24 PM UTC, comment #15: 

test

spiralvoice <spiralvoice>
Project Administrator
Sun 07 Aug 2005 05:53:07 PM UTC, comment #14: 
spiralvoice <spiralvoice>
Project Administrator
Wed 25 May 2005 09:52:03 PM UTC, comment #13: 

donkeyInteractive.ml
let forget_search s =
  if !xs_last_search = s.search_num then begin
      xs_last_search := (-1);
      xs_servers_list := [];
    end;

donkeyUdp.ml
  | Udp.QueryReplyUdpReq t ->
      (* lprintf "Received file by UDP\n"; *)
      if !xs_last_search >= 0 then

So it seems MLDonkey really can currently handle only one UDP
search at a time. Is there a way to distinguish UDP search
results if they were originated by different searches?

On possible solution would be to block the start of a new search
until the previous one has finished. Other solutions?

spiralvoice <spiralvoice>
Project Administrator
Wed 25 May 2005 05:42:47 PM UTC, comment #12: 

This is not overnet related.

1. When starting a new search, donkeySearch.send_search automatically calls DonkeyUdp.make_xs

2. DonkeyUdp.make_xs sets !xs_last_search to this new search number ( xs_last_search := ss.search_num )

3. All future UDP search replies that are received are attached to this new search even if the results are not related (they are related to a previous search)

donkeyUdp.Udp.QueryReplyUdpReq ->
... let ss = search_find !xs_last_search ....

z <zet>
Project Member
Thu 19 May 2005 01:59:52 PM UTC, comment #11: 

Try turning off Overnet. Does the bug still exist then?

spiralvoice <spiralvoice>
Project Administrator
Tue 12 Apr 2005 04:21:04 PM UTC, comment #10: 

MLNet 2.5-30-4: Multi-Network p2p client (Global Shares Gnutella G2 Fasttrack FileTP BitTorrent Donkey)

Searching 2 queries
[Forget] [1    ]CONTAINS[car]  -77 (found 72)
[Forget] [2    ]CONTAINS[3il3i3li3]  -204 (found 179)

MLNet 2.5-30ac_r264M

Searching 4 queries
[Forget] [1    ]CONTAINS[car]  -156 (found 851)
[Forget] [2    ]CONTAINS[ilili3jli3j3il3]  done (found 0)
[Forget] [3    ]CONTAINS[bike]  3 (found 236)
[Forget] [4    ]CONTAINS[bike3i23ild]  -262 (found 179)

Timing matters I guess.  I don't see any patch that addresses this. 

z <zet>
Project Member
Tue 12 Apr 2005 11:11:13 AM UTC, comment #9: 

Don´t have this bug on 2-5-30-4, please try that version.

[3    ]CONTAINS[car]  done (found 1076)
[4    ]CONTAINS[jkjkjjjkkjj]  done (found 0)
[5    ]CONTAINS[madonna]  done (found 1050)
[6    ]CONTAINS[tvrioeufeonitujifz]  done (found 0)
[7    ]CONTAINS[york]  done (found 943)
[8    ]CONTAINS[dcvmtiovnutzvrt]  done (found 0)
[9    ]CONTAINS[hamburg]  done (found 65)
[10   ]CONTAINS[vtzivgutzovgnuz]  done (found 0)
[11   ]CONTAINS[car]  done (found 876)
[12   ]CONTAINS[lwielielieie]  done (found 0)

spiralvoice <spiralvoice>
Project Administrator
Tue 13 Apr 2004 03:05:43 PM UTC, comment #8: 

I'm noticing the same misbehavior with 2.5.16

It happens when search queries are made between short time intervals (< 5 seconds)

Anonymous
Tue 23 Mar 2004 03:19:26 AM UTC, comment #7: 

MLNet 2.5-17: Multi-Network p2p client (Global Shares Direct Connect Open Napster Gnutella G2 Fasttrack FileTP BitTorrent Donkey Soulseek)

set filter_search_delay 1

<save & restart core>

Searching 2 queries
[Forget] [12   ]CONTAINS[car]  -275 (found 627)
[Forget] [13   ]CONTAINS[ilsdifiasldfasdf]  -259 (found 188)

z <zet>
Project Member
Tue 23 Mar 2004 01:52:05 AM UTC, comment #6: 

Maybe this has something to do with filter_search_delay which defaults to 5 seconds, please lower that value to 1 and retry.

spiralvoice <spiralvoice>
Project Administrator
Fri 05 Mar 2004 03:40:55 AM UTC, comment #5: 

I'm only connected to edonkey servers (connected to 4 of 216 at the moment).

Using the web interface, I just type "s car" and immediately "s <garbage>" in the input line.

Searching 2 queries
[Forget] [1    ]CONTAINS[car]  -193 (found 856)
[Forget] [2    ]CONTAINS[3i3lilsidff]  -188 (found 142)

I see that your queries are "done"... mine are not.

z <zet>
Project Member
Fri 05 Mar 2004 12:57:07 AM UTC, comment #4: 

Can´t confirm that one here:

MLNet 2.5-12: Multi-Network p2p client (Global Shares Open Napster Gnutella G2 Fasttrack FileTP BitTorrent Donkey Soulseek)

Searching 2 queries
[Forget] [1    ]CONTAINS[car]  done (found 641)
[Forget] [2    ]CONTAINS[lwielielieie]  done (found 0)

To how many edonkey servers are you connected to?
Do these search results also include other networks than edonkey?
Here I am connected to 3 servers and I use only Edonkey/Overnet.

spiralvoice <spiralvoice>
Project Administrator
Fri 05 Mar 2004 12:14:27 AM UTC, comment #3: 

This is still a problem with 2.5.12. From web interface:

MLNet 2.5-12: Multi-Network p2p client (Global Shares Direct Connect Open Napster Gnutella G2 Fasttrack FileTP BitTorrent Donkey Soulseek)

Searching 2 queries
[Forget] [4    ]CONTAINS[car]  -368 (found 1000)
[Forget] [5    ]CONTAINS[lwielielieie]  -120 (found 94)

z <zet>
Project Member
Wed 25 Feb 2004 01:07:56 AM UTC, comment #2: 

This was done with 2.5-12:

> vs

Searching 2 queries
[5    ]CONTAINS[car]  done (found 803)
[6    ]CONTAINS[kdkdkdkdkd]  done (found 0)
also with Newgui and Sancho. I saw this bug before as stated
but it seems to be solved quietly;-)

spiralvoice <spiralvoice>
Project Administrator
Tue 23 Dec 2003 09:48:20 AM UTC, comment #1: 

same here using newgui

spiralvoice <spiralvoice>
Project Administrator
Tue 23 Dec 2003 06:04:56 AM UTC, original submission:  

2.5.4+2

Search results for one search appear in the results of another.  Simple example:

Search for something very popular. "s car"
Immediately search for something impossible "s liselirijewi"

The results for "liselirijewi" will contain some of the results for "car"...

Donkey/BT are the only networks enabled.

Anonymous

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 12 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-06-23 spiralvoice Reassign ItemFrom group mldonkey, a multi-networks file-sharing client, bugs tracker => To group mldonkey, a multi-networks file-sharing client, task tracker
2006-06-23 spiralvoice SummarySearch results appear in the wrong search. => EDK: Use one UDP port per search
2005-05-19 spiralvoice Release2-5-16 => 2.5.30.15
2004-05-03 spiralvoice Release2-5-12 => 2-5-16
2004-03-15 spiralvoice Severity3 - Normal => 4 - Important
    Release2.5.4+2 =>
2004-03-05 spiralvoice Item GroupNone => Program malfunction
    ReleaseNone => 2-5-12
2004-03-05 zet StatusFixed => None
    Open/ClosedClosed => Open
2004-02-25 spiralvoice StatusNone => Fixed
    Open/ClosedOpen => Closed

Back to the top


Powered by Savane 3.5