bugmldonkey, a multi-networks file-sharing client - Bugs: bug #8705, Missing port value in HTTP Host...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #8705: Missing port value in HTTP Host header

Submitter:  None
Submitted:  Mon 26 Apr 2004 10:51:39 PM UTC
   
 
Category:  HTTP interface Severity:  3 - Normal
Item Group:  Program malfunction Status:  Fixed
Assigned to:  None Open/Closed:  Closed
Release:  2-5-16 Release: 
Operating System:  None Binaries Origin:  CVS / Self compiled
CPU type:  None

Thu 19 Aug 2004 09:17:26 AM UTC, comment #3: 

Fixed CVS 2-5-28

spiralvoice <spiralvoice>
Group administrator
Fri 23 Jul 2004 01:41:44 AM UTC, comment #2: 

This patch does not compile with CVS 2-5-16 and Ocaml-3.08.0:
File "src/utils/net/http_client.ml", line 93, characters 86-89:
This expression is not a function, it cannot be applied

Line 93 is this one:
  Printf.bprintf res " HTTP/1.0\r\nHost: %s%s\r\n" url.server (if url.port != 80 then ":" url.port else "");

spiralvoice <spiralvoice>
Group administrator
Tue 11 May 2004 03:02:59 AM UTC, comment #1: 

I think the problem is in src/utils/net/http_client.ml (see attachment). I don't know whether the syntax in my patch is correct but you should get the idea. The patch corrects also the HTTP User-Agent header. The product version should be separated by a '/' not a whitespace (see RFC 2616 section 3.8). It's a pitty that this header isn't set in one place but all over the place and the caps weren't consistent either.

Anonymous
Mon 26 Apr 2004 10:51:39 PM UTC, original submission:  

When MLDK connects a Gnutella Web Cache the hostname in the Host header is not followed port value even if the server isn't on TCP port 80. For example, if the server is on port 8080, the header should look like this:

Host: gwc.example.com:8080

MLDK however sends this:

Host: gwc.example.com

Which implies port 80. Most HTTP servers probably ignore this, but I wouldn't rely on it. I assume this a generic problem of the HTTP interface and not only in the Gnutella plug-in.

christianbiere at gmx de

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #1297:  mldonkey.udif added by None (6KiB - application/octet-stream - Fixes User-Agent and missing port in Host (against mldonkey-2.5.21))

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2004-08-19 spiralvoice StatusNone Fixed
    Open/ClosedOpen Closed
2004-05-11 None Attached File- Added mldonkey.udif, #1289

Back to the top

Powered by Savane 3.13-758e.
Corresponding source code