bugmldonkey, a multi-networks file-sharing client - Bugs: bug #9697, logic bug in gnutella2 server...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #9697: logic bug in gnutella2 server suppression leads to dropped gnutella servers

Submitter:  None
Submitted:  Tue 20 Jul 2004 06:38:47 AM UTC
   
 
Category:  Gnutella/G2-Plugin Severity:  1 - Wish
Priority:  5 - Normal Item Group:  Program malfunction
Status:  Fixed Assigned to:  None
Open/Closed:  Closed Release:  2-5-21
Release:  Operating System:  Linux
Binaries Origin:  CVS / Self compiled CPU type:  Intel x86

Discussion

Jump to the original submission

Wed 11 Aug 2004 01:55:29 AM UTC, comment #6: 

Latest version in CVS seems to connect to at least one ultrapeer

Constantine Sapuntzakis <csapuntz>
Tue 10 Aug 2004 06:51:14 PM UTC, comment #5: 

Changing severity to 1 because this bug might be solved in current CVS release.

spiralvoice <spiralvoice>
Group administrator
Mon 09 Aug 2004 06:31:58 PM UTC, comment #4: 

Please test CVS 2-5-25 and report if the bugs is still present.

spiralvoice <spiralvoice>
Group administrator
Fri 23 Jul 2004 02:35:15 AM UTC, comment #3: 

I just sent a new patch, please test it.

spiralvoice <spiralvoice>
Group administrator
Thu 22 Jul 2004 04:28:10 AM UTC, comment #2: 

With my proposal, all gnutella2 peers are dropped in gnutella2.

I don't know the answer to this. It seems that the #include
hack is not rich enough to encompass all the differences
between gnutella and gnutella2.

The code needs to be in gnutellaServers.ml:

if !gnutella2 then
    failwith "Gnutella2 not supported"

and in g2Servers.ml:

if not !gnutella2 then
    failwith "Gnutella servers not supported"

I suspect. The enable flag test looks like a hack to me.
But I could be wrong...

Actually, now that I'm writing this, I have a question.
Is the gnutella2 code mean to work with gnutella servers?

Anonymous
Tue 20 Jul 2004 12:27:33 PM UTC, comment #1: 

Wouldn´t this break the use of Gnutella2 peers? The file gnutellaServers.ml will be copied as g2Servers.ml because of src/networks/gnutella2/g2Servers.mlt. Now all not-gnutella peers are dropped, with your proposal all not-G2 peers would be dropped.
What about this patch:

diff -x Root -x Repository -x Entries -x '*.orig' -u -N -r ./src/networks/gnutella/gnutellaServers.ml ./src/networks/gnutella/gnutellaServers.ml
--- ./src/networks/gnutella/gnutellaServers.ml  2004-03-07 10:34:27.000000000 +0100
+++ ./src/networks/gnutella/gnutellaServers.ml  2004-07-20 14:21:26.000000000 +0200
@@ -234,7 +234,7 @@
     if proto < "0.6" then
       failwith (Printf.sprintf "Bad protocol [%s]" proto)
     else
-    if not (!gnutella2) then
+    if !gnutella2 && not (!!enable_gnutella2) then
       failwith "Protocol Gnutella2 not supported"
     else
     if code <> "200" then begin

spiralvoice <spiralvoice>
Group administrator
Tue 20 Jul 2004 06:38:47 AM UTC, original submission:  

Line 237 of gnutellaServers.ml

if not (!gnutella2) then

should be

if !gnutella2 then

Anonymous

 

Attached Files

Attached Files
file #1577:  gnutella.patch added by spiralvoice (1.9KiB - application/octet-stream - What about this patch (untested)?)

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

 

Votes

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

History

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2004-08-15 spiralvoice StatusNone Fixed
    Open/ClosedOpen Closed
2004-08-10 spiralvoice Severity3 - Normal 1 - Wish
2004-07-23 spiralvoice Attached File- Added gnutella.patch, #1515

Back to the top

Powered by Savane 3.16-ed84.
Corresponding source code