bugmldonkey, a multi-networks file-sharing client - Bugs: bug #9764, bandwidth waste: stupid response...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #9764: bandwidth waste: stupid response on Sources Answer

Submitter:  None
Submitted:  Mon 26 Jul 2004 12:42:15 AM UTC
   
 
Category:  eDonkey-Plugin Severity:  3 - Normal
Item Group:  Program malfunction Status:  Wont Fix
Assigned to:  None Open/Closed:  Closed
Release:  2-5-21 Release: 
Operating System:  Linux Binaries Origin:  CVS / Self compiled
CPU type:  Intel x86

Jump to the original submission

Thu 21 Jul 2005 04:35:54 PM UTC, comment #6: 

This patch report is old. If the bug still exists in current
versions please post a new bug report - spiralvoice

spiralvoice <spiralvoice>
Group administrator
Thu 19 May 2005 12:49:22 AM UTC, comment #5: 

Please check if this bug still is in current CVS version.
You should find a tarball of current CVS in files section of
this project: http://download.berlios.de/pub/mldonkey/spiralvoice/

spiralvoice <spiralvoice>
Group administrator
Sat 21 Aug 2004 09:17:16 PM UTC, comment #4: 

Since those IPs come from what should be a Direct_address list, it shows how much crap is being kept...
IMHO a best fix would be to prevent them from being added to sources lists in the first place...

Anonymous
Wed 11 Aug 2004 10:52:59 AM UTC, comment #3: 

well, regarding parsing the packets, I rely on ethereal (and my little knowledge about edonkey protocol).
but I can see the values in the hexpacket, so I am sure, they are shown right. The packets have been captured with tcpdump (snapsize 1024 byte), so think I also can rely on that..

I checked back.
I am downloading a file, with 19 chunks (said by files.ini), 2 found sources (said by file_sources), and got this attached packet on wire.

there are 40 IP's in that packet.

some 0.0.0.0 IP's have a port assigned
some IP's in there are without a port
some IP's are just illegal (Network-addr, start with 0.0, etc. p.p.)

I have force_high_id enabled .. I have a direct connection to the net .. shouldn't the whole packet then be 0.0.0.0 ?



Anonymous
Mon 09 Aug 2004 05:47:23 PM UTC, comment #2: 

Are you sure of your method to parse the packets ? Message 0x82 in sourceexchange > 1 is supposed to contain, for each source, its IP address and port, the IP address and port of the server (or zeros if HIGH-ID), and the UID of the source (which is not known by mldonkey since it doesn't keep this information, thus sending a lot of zeroes again).

mldonkey admin <mldonkey>
Group administrator
Mon 26 Jul 2004 01:08:19 PM UTC, comment #1: 

its even worse than i thought.
bash-2.05b$ grep IP /tmp/networkbug | sort | uniq -c
     28         IP: 0.0.0.0 (0.0.0.0)
      1         IP: 0.0.217.157 (0.0.217.157)
      1         IP: 0.0.217.235 (0.0.217.235)
      1         IP: 0.0.82.80 (0.0.82.80)
      1         IP: 146.16.0.0 (146.16.0.0)
      1         IP: 210.192.25.82 (210.192.25.82)
      1         IP: 217.234.39.184 (217.234.39.184)
      1         IP: 24.196.54.18 (24.196.54.18)
      1         IP: 4.92.54.18 (4.92.54.18)
      2         IP: 54.18.0.0 (54.18.0.0)
      1         IP: 62.147.213.190 (62.147.213.190)
      1         IP: 68.157.54.18 (68.157.54.18)

28 IP's with 0.0.0.0 (nonsense)
3 IP's with 0.0.x.x (nonsense)
2 IP's with x.x.0.0 (class B network address = nonsense)

makes 33 from 40 IP's which are nonsense.

Suggested QuickFix: just send every addr/port-pair once.



Anonymous
Mon 26 Jul 2004 12:42:15 AM UTC, original submission:  

MlDonkey wastes bandwidth with stupid responses to emules extension. "File Request Answer (0x85) [0xc5 <int msgsize> 0x85]" often gives out a
"ip: 0.0.0.0; port: 0" konfiguration, multiple times.

from ethereal:
00e0  80 04 ->> c5 8b 05 00 00 82<<--  6e d2 d2 57 c0 d4 77 f4   ........ n..W..w.
00f0  93 70 d4 e9 05 a4 2d ad  32 00 d5 a8 68 e8 36 12   .p....-. 2...h.6.
0100  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00   ........ ........
0110  00 00 00 00 00 00 50 90  a2 5a 36 12 00 00 00 00   ......P. .Z6.....
0120  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00   ........ ........
0130  00 00 52 30 17 f1 39 12  00 00 00 00 00 00 00 00   ..R0..9. ........
0140  00 00 00 00 00 00 00 00  00 00 00 00 00 00 d9 5e   ........ .......^
0150  b9 f2 36 12 00 00 00 00  00 00 00 00 00 00 00 00   ..6..... ........
0160  00 00 00 00 00 00 00 00  00 00 53 68 2e da 36 12   ........ ..Sh..6.
0170  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00   ........ ........
0180  00 00 00 00 00 00 52 50  c1 36 1e 16 00 00 00 00   ......RP .6......
0190  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00   ........ ........
01a0  00 00 53 1a f2 dc 36 12  00 00 00 00 00 00 00 00   ..S...6. ........

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #1642:  details added by None (8KiB - application/octet-stream - ethereal packet log)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-07-21 spiralvoice StatusNeed Info Wont Fix
    Open/ClosedOpen Closed
2005-05-19 spiralvoice StatusNone Need Info
2004-08-11 None Attached File- Added details, #1575

Back to the top

Powered by Savane 3.12