monotone - Bugs: bug #12221, unify bad_decode() and error()
You are not allowed to post comments on this tracker with your current authentication level.
bug #12221: unify bad_decode() and error()
Submitter: | Nathaniel Smith <njs> | ||
Submitted: | Sat 05 Mar 2005 10:44:10 AM UTC | ||
Category: | networking | Severity: | 1 - Wish |
Item Group: | code cleanup | Status: | None |
Privacy: | Public | Assigned to: | None |
Open/Closed: | Open | ||
mtn version --full: |
|
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
CC list is empty
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
No changes have been made to this item
Powered by Savane 3.13-3230.
Corresponding source code
we have two different ways of reporting errors in netsync. the advantage of bad_decode is that it triggers a transaction rollback. the advantage of error is that it informs the peer of the error before shutting down the connection.
these should be merged into a single error-reporting functionality, so that all errors inform the peer of the problem (a significant usability improvement), and all errors trigger a database rollback.
beware of 2nd-level errors encountered while informing the peer of an error -- these must be handled correctly as well (presumably by giving up on telling the peer anything useful and just shutting down the connection immediately).