bugQuilt - Bugs: bug #20628, Quilt checks for duplicate patches...

 
 

bug #20628: Quilt checks for duplicate patches circumvented if using a generated series file

Submitter:  None
Submitted:  Mon 30 Jul 2007 05:48:44 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  khali
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 02 Mar 2014 12:13:32 PM UTC, comment #3: 
Jean Delvare <khali>
Group administrator
Fri 28 Feb 2014 09:27:14 AM UTC, comment #2: 

The first candidate fix is bad performance-wise. We call grep and sed for every patch we check, and the list we grep grows with every patch we apply, making it an O(n^2) algorithm.

I benchmarked this patch on a very large patch series (14805 patches) and "quilt push -qa" took ~25% more time to complete. This is hardly acceptable.

Meanwhile I came up with a smarter and faster way to check for duplicate patches in series, I'll attach it.

Jean Delvare <khali>
Group administrator
Wed 26 Feb 2014 02:56:32 PM UTC, comment #1: 

The problem is still present in version 0.61, and I agree it should be addressed.

Jean Delvare <khali>
Group administrator
Mon 30 Jul 2007 05:48:44 AM UTC, original submission:  

If using quilt with a guards generated series file the normal
checks to prevent a patch with the same name being created are
circumvented.

While this is not a problem with quilt it would be nice if quilt
prevented the attempt to push an existing patch and issued a warning.

Quilt commands get very confused when this happens and it can be
tricky to recover from.

$ quilt --version
0.46

--
Donald

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #30731:  quilt-push-check-applied-2.patch added by khali (2KiB - text/x-patch - Second candidate fix)
file #30714:  quilt-push-check-applied.patch added by khali (2KiB - text/x-patch - Candidate fix)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by khali (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-03-02 khali StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2014-02-28 khali Attached File- Added quilt-push-check-applied-2.patch, #30731
    2014-02-26 khali Attached File- Added quilt-push-check-applied.patch, #30714
    2014-02-26 khali StatusNone Confirmed
        Assigned toNone khali

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code