bugcolor-theme - Bugs: bug #31769, Some themes set properties that...

 
 

bug #31769: Some themes set properties that should not be buffer-local

Submitter:  Jim Burton <jimburton>
Submitted:  Fri 03 Dec 2010 10:57:32 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  General error Status:  None
Assigned to:  None Open/Closed:  Open
Reproducibility:  Every Time
Step by step reproducibility:  *

M-: (setq color-theme-is-global nil)
M-x color-theme-clarity
M-x w3m

* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 05 Oct 2011 12:04:05 AM UTC, comment #1: 

The problem (if not the solution) is explained in this thread: http://www.opensubscriber.com/message/emacs-devel@gnu.org/9748929.html

David Abrahams <bewst>
Fri 03 Dec 2010 10:57:32 AM UTC, original submission:  

This problems occurs when using color-theme and emacs-w3m, although it may occur when color-theme interacts with other packages too. I am using Gnu Emacs 23.2.1, color-theme 6.6.0-4 installed via the Arch Linux package, and emacs-w3m-cvs 20100930-1. If I set color-theme-is-global to nil, use one of the themes that sets `widget-mouse-face' to `highlight', such as color-theme-clarity, then I get an error when starting emacs-w3m:

w3m-setup-widget-faces: Symbol widget-mouse-face may not be buffer-local

and w3m fails to load. I have checked that this happens without any of my other config, i.e. starting with nothing, loading color-theme, setting color-theme-is-global, loading w3m etc. I have worked around like so:

;; color-theme.el
(defmacro when-color-theme-is-global (prop)
  "Return prop if color-theme-is-global is true.

  Use this to wrap alist settings that should only be made
  when color-theme-is-global is false, such as widget-mouse-face
  and possibly others."
  (when color-theme-is-global prop))

Then in color-theme-library.el, replace

(widget-mouse-face . highlight)

with
   
(when-color-theme-is-global '(widget-mouse-face . highlight))

I've attached a patch.

Jim Burton

Jim Burton <jimburton>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #22113:  color-theme.jb-2010-12-01.patch added by jimburton (25KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bewst (Posted a comment)
  • -email is unavailable- added by jimburton (Submitted the item)
  •  

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-12-03 jimburton Carbon-CopyRemoved jimburton -
    2010-12-03 jimburton Attached File- Added color-theme.jb-2010-12-01.patch, #22113
        Carbon-Copy- Added jimburton

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code