bugBos Wars - Bugs: bug #34255, Crashes on patch creation, BosWars...

 
 

bug #34255: Crashes on patch creation, BosWars 2.6.1, Windows7

Submitter:  Tristan <tedious>
Submitted:  Thu 08 Sep 2011 09:55:50 PM UTC
   
 
Severity:  4 - Important Item Group:  * Bug
Status:  In Progress Privacy:  Public
Assigned to:  None Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 17 Mar 2017 10:10:07 PM UTC, comment #5: 

Whoa buddy, just realized what I wrote last year came across jerk-ish xD

Apologies!

Tristan <tedious>
Sat 23 Apr 2016 09:40:15 PM UTC, comment #4: 

Unfortunately, the suggestion by kon still needs to be implemented.

François Beerten <feb>
Group administrator
Tue 19 Apr 2016 08:25:38 PM UTC, comment #3: 

Long time... 4 years huh?

I agree with kon's assessment. Has this been implemented?

Tristan <tedious>
Fri 03 Aug 2012 07:40:44 AM UTC, comment #2: 

I got a SIGSEGV with Bos Wars 2.6.1 on Debian wheezy (libstdc++6:amd64 4.7.1-2) when I tried to create a patch with a missing graphic file.  This may be the same bug that caused your crash in Windows.  Fixed in trunk r10049 (2011-03-05) and boswars-2.6 r10190 (2012-08-03).  With that fix, Bos Wars still exits, but cleanly.

I think it would be better not to exit in this scenario.  Instead pop up an error message and let the user return to the menu.  For that reason, I'm not marking this bug fixed yet.

The same error could in principle happen when loading a map (for editing or for playing) that uses patches with missing graphics.  Then, there might be dozens of such patches, and we should show the whole list to the user rather than just the first one.  Could even show the map, drawing rectangles as placeholders for the missing graphics, and display the error message in front of that.  What do you think?

Kalle Olavi Niemitalo <kon>
Group Member
Fri 06 Jan 2012 06:48:29 PM UTC, comment #1: 

Kon did many improvements to the UI for creating patches starting at revision 9841. Now the image to use can be selected with a file browser. It will land in the next release.

Currently, te edit box with the image file is still editable which could create the same problem again. Ideally, we should remove the edit box with the image file or replace it with a read only text widget.

François Beerten <feb>
Group administrator
Thu 08 Sep 2011 09:55:50 PM UTC, original submission:  

Windows 7 32 bit
Intel Core2Duo
4GiB RAM
Intel G41 Express Chipset

To recreate:

From Main Menu->Start Editor->Patch Editor->Create New Patch:

Name: name
Image: plain4.png
Size: 64x64

->[Create Patch]


To avoid:

In the image field prepend: patches/

For example: patches/plain4.png

Doesn't crash if the patches/ string is prepended.


Application crash, Windows output(Don't know how useful this is):

Problem signature:
  Problem Event Name: APPCRASH
  Application Name: boswars.exe
  Application Version: 0.0.0.0
  Application Timestamp: 4bcb39f6
  Fault Module Name: boswars.exe
  Fault Module Version: 0.0.0.0
  Fault Module Timestamp: 4bcb39f6
  Exception Code: c0000005
  Exception Offset: 000f56b4
  OS Version: 6.1.7601.2.1.0.256.48
  Locale ID: 1033
  Additional Information 1: 0a9e
  Additional Information 2: 0a9e372d3b4ad19135b953a78882e789
  Additional Information 3: 0a9e
  Additional Information 4: 0a9e372d3b4ad19135b953a78882e789

Read our privacy statement online:
  http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0409

If the online privacy statement is not available, please read our privacy statement offline:
  C:\Windows\system32\en-US\erofflps.txt

Tristan <tedious>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by kon (Posted a comment)
  • -email is unavailable- added by feb (Posted a comment)
  • -email is unavailable- added by tedious (Submitted the item)
  • -email is unavailable- added by tedious (Added the bug, let me know if it needs more info)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-01-06 feb Severity3 - Normal 4 - Important
        StatusNone In Progress
    2011-09-08 tedious Carbon-Copy- Added feb

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code