bugAVR Downloader/UploaDEr - Bugs: bug #40108, [PATCH] Fix avrftdi verification...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #40108: [PATCH] Fix avrftdi verification error after flash write

Submitter:  Nemui Trinomius <nemuisan>
Submitted:  Thu 26 Sep 2013 03:22:18 AM UTC
   
 
Category:  None Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  None Privacy:  Public
Assigned to:  hweisbach Originator Name:  Nemui
Open/Closed:  Open Release:  None
Programmer hardware:  Device type: 

Wed 11 Dec 2013 04:49:07 AM UTC, comment #2: 

Dear hweisbach,
Sorry for my late reply.

I tested your patch and got work well.
Please see attached report for detail.
(file #29858)

Nemui Trinomius <nemuisan>
Thu 26 Sep 2013 10:28:56 AM UTC, comment #1: 

Thank you for reporting this.

Can you supply a log with -vvvvv as parameters to avrdude as well as the binary you are programming?
I am not accepting this patch as-is because (more or less) randomly resetting programmers is usually not the solution to the problem. In fact, the code is commented with a TODO, which already states what has to be done: /* TODO sync write */.
This means the flush part of write_flush() has to be called.

I've attached a patch (against r1248) implementing this TODO. Could you please try it and report back if they work (apply with -p1)?

(file #29223)

Hannes Weisbach <hweisbach>
Group Member
Thu 26 Sep 2013 03:22:18 AM UTC, original submission:  

When write flash below sector size,usually polling byte cannot found.
In this case,verify flash after flash write always fail.

Tested with ATmega1284p(has 256byte sector size).
202byte(<256byte) binary fail,but over 256byte binaries was Ok.

Attached patch fixes this problem to re-initialize avrftdi when polling byte cannot be found.

Nemui Trinomius <nemuisan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #29858:  avrftdi_testing_report.7z added by nemuisan (18KiB - application/x-7z-compressed)
file #29223:  avrftdi_sync.patch added by hweisbach (3KiB - application/octet-stream)
file #29218:  avrdude_avrftdi_fix.patch added by nemuisan (1KiB - application/octet-stream)
file #29219:  failure_orig_dude.log added by nemuisan (4KiB - application/octet-stream)
file #29220:  success_patched_dude.log added by nemuisan (4KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by hweisbach (Updated the item)
  • -email is unavailable- added by nemuisan (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-12-11 nemuisan Attached File- Added avrftdi_testing_report.7z, #29858
    2013-09-26 hweisbach Attached File- Added avrftdi_sync.patch, #29223
        Assigned toNone hweisbach
    2013-09-26 nemuisan Attached File- Added avrdude_avrftdi_fix.patch, #29218
        Attached File- Added failure_orig_dude.log, #29219
        Attached File- Added success_patched_dude.log, #29220

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code