lwIP - A Lightweight TCP/IP stack - Bugs: bug #19729, pbuf_free problem
You are not allowed to post comments on this tracker with your current authentication level.
bug #19729: pbuf_free problem
Submitter: | Cui hengbin <phant> | ||
Submitted: | Sat 28 Apr 2007 08:28:21 AM UTC | ||
Category: | pbufs | Severity: | 3 - Normal |
Item Group: | Crash Error | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | None |
Jump to the original submission
Thu 17 May 2007 09:06:57 AM UTC, comment #9: |
Simon Goldschmidt <goldsimon> |
Wed 16 May 2007 08:59:04 PM UTC, comment #8: So, if current ethernetif.c is good, you should remove pbuf_free(p) from tcpip_input & tcpip_ethinput in tcpip.c, when "msg = memp_malloc(MEMP_TCPIP_MSG);" failed, like you have propose in comment #2, no ?
|
Frédéric Bernon <fbernon> |
Wed 16 May 2007 07:55:04 PM UTC, comment #7: ethernetif.c is already up to date, checked in the others.
|
Simon Goldschmidt <goldsimon> |
Wed 16 May 2007 07:01:14 PM UTC, comment #6: Ok, no problem for me !!! Can you just also update ethernetif.c ?
|
Frédéric Bernon <fbernon> |
Wed 16 May 2007 06:58:54 PM UTC, comment #5: Frédéric, can I check in loopif.c, ppp.c & slipif.c that check netif->input() return value and delete p if != NULL?
|
Simon Goldschmidt <goldsimon> |
Mon 30 Apr 2007 11:52:05 AM UTC, comment #4: So I think we should update loopif to free the pbuf if netif->input() fails!
|
Simon Goldschmidt <goldsimon> |
Sun 29 Apr 2007 09:22:41 PM UTC, comment #3: I'm agree With Simon is we only study ethernetif use, but I'm not sure if loopif and ppp interface handle that correctly :
|
Frédéric Bernon <fbernon> |
Sun 29 Apr 2007 10:30:46 AM UTC, comment #2: I think it would be better to change tcpip.c (tcpip_input() and tcpip_ethinput()) not to free the pbuf but simply returning != ERR_OK and letting the ethernet driver free the pbuf. I think that's more consistent behaviour. |
Simon Goldschmidt <goldsimon> |
Sun 29 Apr 2007 03:29:30 AM UTC, comment #1:
|
Cui hengbin <phant> |
Sat 28 Apr 2007 08:28:21 AM UTC, original submission:
Hi ALL:
|
Cui hengbin <phant> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-05-17 | goldsimon | Status | None | Fixed | |
Open/Closed | Open | Closed | |||
2007-05-16 | fbernon | Assigned to | fbernon | goldsimon | |
2007-05-03 | fbernon | Assigned to | None | fbernon |
Powered by Savane 3.13-f8d8.
Corresponding source code
You're right. Done that. Reading the code I ask myself why ip_input has a return type of err_t instead of void since it always returns ERR_OK and frees the pbuf itself.
OK, but now I'll really close it as fixed.