lwIP - A Lightweight TCP/IP stack - Bugs: bug #37184, tcp_write problem for pcbs in the...
You are not allowed to post comments on this tracker with your current authentication level.
bug #37184: tcp_write problem for pcbs in the SYN_SENT state
Submitter: | Zach Smith <zsmith> | ||
Submitted: | Fri 24 Aug 2012 10:43:58 PM UTC | ||
Category: | TCP | Severity: | 3 - Normal |
Item Group: | Faulty Behaviour | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | 1.4.0 |
Tue 20 May 2014 08:13:23 PM UTC, comment #5: |
Simon Goldschmidt <goldsimon> |
Tue 20 May 2014 08:07:08 PM UTC, comment #4: I guess this is a simple regression: when making the change of limiting the segment size to half the maximum send window we received (to ensure getting delayed ACKs), we just didn't think pcb->snd_wnd_max would ever be zero.
|
Simon Goldschmidt <goldsimon> |
Thu 13 Sep 2012 08:16:50 PM UTC, comment #3: also, it seems that older versions of tcp_write did this |
Zach Smith <zsmith> |
Thu 13 Sep 2012 08:09:38 PM UTC, comment #2: Maybe this is too simple but it seems to me like an easy solution to this would be to use the minimum TCP MSS in this case where we haven't received the other hosts advertised MSS yet. So, something like this:
|
Zach Smith <zsmith> |
Sun 26 Aug 2012 10:23:16 AM UTC, comment #1: I think technically 0 is the right answer for "how much data can we send" in this case, but I'll need to look at the code to see how that mss_local value is being used and work out the best way to improve it. 0 is not the right value for the MSS.
|
Kieran Mansley <kieranm> |
Fri 24 Aug 2012 10:43:58 PM UTC, original submission:
if the pcb passed to tcp_write is in the state SYN_SENT then this line:
|
Zach Smith <zsmith> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2014-05-20 | goldsimon | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2014-05-20 | goldsimon | Status | None | In Progress | |
Assigned to | None | goldsimon | |||
2012-08-24 | zsmith | Carbon-Copy | - | Added -email is unavailable- |
Powered by Savane 3.13-4448.
Corresponding source code
Fixed by using pcb->mss if mss_local gets zero.
Thanks for reporting.