lwIP - A Lightweight TCP/IP stack - Bugs: bug #50614, TCP: new ACK processing, unsent...
You are not allowed to post comments on this tracker with your current authentication level.
bug #50614: TCP: new ACK processing, unsent queue check and pcb->sndbuf update in wrong spot
Submitter: | Joel Cunningham <jcunningham> | ||
Submitted: | Wed 22 Mar 2017 09:17:57 PM UTC | ||
Category: | TCP | Severity: | 3 - Normal |
Item Group: | Change Request | Status: | Fixed |
Privacy: | Public | Assigned to: | jcunningham |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Jump to the original submission
Wed 29 Mar 2017 09:33:01 PM UTC, comment #8: |
Joel Cunningham <jcunningham> |
Wed 29 Mar 2017 08:03:24 PM UTC, comment #7:
|
Joel Cunningham <jcunningham> |
Wed 29 Mar 2017 07:57:37 PM UTC, comment #6:
|
Simon Goldschmidt <goldsimon> |
Wed 29 Mar 2017 07:56:43 PM UTC, comment #5:
|
Joel Cunningham <jcunningham> |
Wed 29 Mar 2017 07:55:04 PM UTC, comment #4: I agree that ACKs <= pcb->lastack would no longer invoke the check of pcb->unsent. Checking pcb->unsent for that case should NOT be unnecessary because we would have already performed the check when lastack was updated. The only way a segment could remain is if the ACK didn't fully ack the segment, at which-point an ACK greater than lastack would be required to ACK it. Further, if a check was really needed in that case, it should also be performed on unacked as well (which hasn't been the case)
|
Joel Cunningham <jcunningham> |
Wed 29 Mar 2017 06:40:28 PM UTC, comment #3: Sorry, this somehow slipped through...
|
Simon Goldschmidt <goldsimon> |
Wed 29 Mar 2017 01:43:29 PM UTC, comment #2: Ping, any one get a chance to look at this yet?
|
Joel Cunningham <jcunningham> |
Wed 22 Mar 2017 10:02:39 PM UTC, comment #1: Attached is patch doing two things:
|
Joel Cunningham <jcunningham> |
Wed 22 Mar 2017 09:17:57 PM UTC, original submission:
See discussion on lwip-devel: http://lists.nongnu.org/archive/html/lwip-devel/2017-03/msg00149.html |
Joel Cunningham <jcunningham> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-03-29 | jcunningham | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2017-03-22 | jcunningham | Attached File | - | Added 0001-bug-50614-move-unsent-queue-check-pcb-snd_buf-update.patch, #40082 |
Powered by Savane 3.13-758e.
Corresponding source code
Committed in c72226114279adb7b5696c49913624add1dc1f33
I'll open a new task for combining the queue processing loops