lwIP - A Lightweight TCP/IP stack - Bugs: bug #51701, lwip_fcntl signature is incorrect
You are not allowed to post comments on this tracker with your current authentication level.
bug #51701: lwip_fcntl signature is incorrect
Submitter: | Ray Bellis <raybellis> | ||
Submitted: | Wed 09 Aug 2017 09:49:34 AM UTC | ||
Category: | sockets/netconn | Severity: | 3 - Normal |
Item Group: | Compiler Warning | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Fri 25 Aug 2017 08:08:09 PM UTC, comment #5: |
Simon Goldschmidt <goldsimon> |
Tue 22 Aug 2017 08:04:45 PM UTC, comment #4:
|
Simon Goldschmidt <goldsimon> |
Fri 11 Aug 2017 10:41:54 PM UTC, comment #3: That should have read unlike varargs, not "unless" ! |
Ray Bellis <raybellis> |
Fri 11 Aug 2017 10:25:09 PM UTC, comment #2: There's already code using <stdarg.h> in src/include/netif/ppp/ppp_impl.h
|
Ray Bellis <raybellis> |
Fri 11 Aug 2017 06:33:23 PM UTC, comment #1: Well, from the standards point of view, you're right. I guess the implementation is like it is to prevent using potentially unportable varargs code... |
Simon Goldschmidt <goldsimon> |
Wed 09 Aug 2017 09:49:34 AM UTC, original submission:
The usual signature for fcntl is (int, int, ...), but lwIP uses an int instead of the varargs for the final parameter.
|
Ray Bellis <raybellis> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-08-25 | goldsimon | Status | None | Fixed | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed |
Powered by Savane 3.13-4448.
Corresponding source code
Fixed for LWIP_COMPAT_SOCKETS == 2 && LWIP_POSIX_SOCKETS_IO_NAMES.
Actually, the summary is wrong as it's 'fnctl' which has a different signature, not 'lwipo_fnctl' -> fixed in that spirit.