bugLibCVS Perl Implementation - Bugs: bug #14188, Cleaning up paths in...


bug #14188: Cleaning up paths in RepositoryFileOrDirectory

Submitted by:  Alexander Taler <dissent>
Submitted on:  Wed 17 Aug 2005 04:42:30 PM UTC  
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Release: NoneFixed Release: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Wed 17 Aug 2005 04:42:30 PM UTC, original submission:

In the constructor of RepositoryFileOrDirectory,
File::Spec is used to clean up the supplied path.
But this doesn't do quite enough. Most
importantly I want to make sure it points into the
repository, by looking for "../".

Perhaps "foo/../bar" could be changed to "bar",
but how is this handled with symlinks?

------- Additional comments from Alexander Taler Thu Jun 26 12:58:38 -0700 2003 -------

The routine get_directory_of totally screws up if there is a .. in the
path. This is a good reason to fix it.

------- Additional comments from Alexander Taler Sun May 16 10:04:28 -0700 2004 -------

Also, the question is if absolute paths should be treated
as relative the repository root. This would be useful for
programs (like lcvs-logsummary) which can accept absolute
paths to indicate files relative the repository root, and
relative paths to indicate files relative to the cwd.

For the moment I'm just going to strip off the leading /
before submitting the filename.

Alexander Taler <dissent>
Project Administrator


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


CC list is empty


Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.


Please enter the title of George Orwell's famous dystopian book (it's a date):



No Changes Have Been Made to This Item

Back to the top

Powered by Savane 3.1-cleanup