bugConcurrent Versions System - Bugs: bug #14591, Disallow addition of directories...

 
 

bug #14591: Disallow addition of directories which look like cvs lock dirs or files.

Submitted by:  Derek Robert Price <dprice>
Submitted on:  Mon 19 Sep 2005 07:24:41 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: OpenRelease: 
Fixed Release: NoneFixed Feature Release: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 11 Feb 2006 01:16:02 PM UTC, comment #3:

Jim++

Ville Skyttä <scop>
Sat 11 Feb 2006 01:07:13 AM UTC, comment #2:

Do we really want to skip the check if LockDir is set? I'm thinking of a scenario where LockDir is set, then the user adds a #cvs.lock file/directory, then CVS is reconfigured to remove the LockDir. Is that a likely scenario?

Jim Hyslop <jhyslop>
Project Member
Mon 19 Sep 2005 07:33:00 PM UTC, comment #1:

Skip this check when LockDir is set, if the patch does not already do so.

Derek Robert Price <dprice>
Project Administrator
Mon 19 Sep 2005 07:24:41 PM UTC, original submission:

- As a robustness, when LockDir is not being used, it may
be desirable to prohibit directories that look like cvs
internal lock files.
https://ccvs.cvshome.org/issues/show_bug.cgi?id=183

From https://ccvs.cvshome.org/issues/show_bug.cgi?id=183:

Currently with CVS 1.11.15 (and I assume later versions too) it's possible to
shoot oneself in the foot (if CVS has been configured to place locks in the repo):

$ mkdir "#cvs.lock"
$ cvs add "#cvs.lock"
Directory /foo/bar/#cvs.lock added to the repository
$ cvs up
cvs update: Updating .
cvs update: [19:03:31] waiting for scop's lock in /foo/bar

I'm suggesting that CVSLCK would be a banned dir/file name. Will attach a patch.

------- Additional comments from Ville Skyttä Thu Jun 3 12:08:16 -0700 2004 -------

Created an attachment (id=82)
Disallow adding CVSLCK (against 1.12.8, untested but trivial: "should work")

------- Additional comments from Derek Price Thu Jun 3 12:21:19 -0700 2004 -------

Sounds like a plan.

Derek Robert Price <dprice>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #3182:  cvs-lock.patch added by dprice (2kB - text/x-patch - Ville's untested patch.)

 

Depends on the following items: None found

Items that depend on this one

Digest:
   task dependencies.

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 19 Sep 2005 07:24:42 PM UTCdpriceAttached File-=>Added cvs-lock.patch, #2968
  Carbon-Copy-=>Added -unavailable-

Back to the top


Powered by Savane 3.1-cleanup