bugConcurrent Versions System - Bugs: bug #23093, contrib/rcslock.in script fails...

 
 

bug #23093: contrib/rcslock.in script fails with perl taint mode enabled

Submitted by:  John Perkins <jperkins71>
Submitted on:  Mon 28 Apr 2008 04:42:57 PM UTC  
 
Category: Bug Fix (patch attached)Severity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: OpenRelease: 
Fixed Release: NoneFixed Feature Release: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 28 Apr 2008 04:42:57 PM UTC, original submission:

The "rcslock" script, shipped as contrib/rcslock.in in current CVS releases, fails when enabling perl's "taint" mode. This issue exists in stable and feature releases.

Attached is a patch that attempts to avoid taint mode failures:
- current directory is determined using perl's Cwd module
rather than exec'ing /bin/pwd
- arguments are passed through a regular expression, to
provide minimal argument checking, before passing them to
perl's chdir() in an effort to untaint those arguments

John Perkins <jperkins71>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15545:  rcslock.patch added by jperkins71 (3kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jperkins71 (Submitted the item)
  • -unavailable- added by jperkins71
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 28 Apr 2008 04:42:57 PM UTCjperkins71Attached File-=>Added rcslock.patch, #15545
      Carbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup