bugSystem V style init programs - Bugs: bug #36528, [PATCH] [bootlogd] Remove handling...

 
 

bug #36528: [PATCH] [bootlogd] Remove handling of special chars; fix per line buffer problem

Submitted by:  None
Submitted on:  Tue 22 May 2012 08:21:53 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 11 Oct 2012 01:59:36 PM UTC, comment #3:

I've done some more tweaking after that comment, but figured this bugtracker was dead so I didn't bother posting.

Current bootlogd as used in Arch Linux can be found here: http://git.server-speed.net/users/flo/bootlogd/

Florian Pritz <bluewind>
Thu 11 Oct 2012 12:50:59 PM UTC, comment #2:

No idea if this would be correct ... maybe one of the Debian people should have a closer look. AFAIK from blogd here around decolouring is a major feature as otherwise some of the codes will destroy readability (codes for TERM=linux readed on TERM=xterm)

Dr. Werner Fink <wfink>
Project Administrator
Sat 16 Jun 2012 02:38:34 PM UTC, comment #1:

Turns out I broke some real features here too (like the ringbuffer keeping not yet written lines). Better patch attached.

(file #26047)

Florian Pritz <bluewind>
Tue 22 May 2012 08:21:53 PM UTC, original submission:

The linebuffer was only 256 chars so longer lines were truncated in the log file.

By removing the handling of special chars (for example: /n/r/t) and simply writing everything we read as is to the logfile we fix this bug, make the code much smaller and allow users to write userspace tools that correctly handle rendering.

I've copied bootlogd.c into a personal git repo so the attached patch is made with git rather than svn, but that shouldn't be a problem.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bluewind (Updated the item)
  • -unavailable- added by bluewind
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 16 Jun 2012 02:38:34 PM UTCbluewindAttached File-=>Added 0001-simplify-writelog.patch, #26047
    Tue 22 May 2012 08:35:34 PM UTCbluewindCarbon-Copy-=>Added bluewind
    Tue 22 May 2012 08:21:53 PM UTCNoneAttached File-=>Added 0001-Remove-handling-of-special-chars-fix-per-line-buffer.patch, #25909

    Back to the top


    Powered by Savane 3.1-cleanup