bugIdentica mode - Bugs: bug #38320, Change handling of faces in...

 
 

bug #38320: Change handling of faces in timelines.

Submitted by:  Jason F. McBrayer <jfmcbrayer>
Submitted on:  Tue 12 Feb 2013 08:57:21 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 12 Feb 2013 08:57:21 PM UTC, original submission:

For some time now, the way faces are handled in identica-mode has bothered me. Basically, you set the background in a defcustom'ed variable. The faces themselves get created on startup, and have their attributes set when the timeline is rendered. One effect of this is that customize-face on those faces is ignored.

I've removed those defcustom'ed variables, and replaced them with defface'd faces, with the same default values. IMO, this is more consistent with normal face usage. The only loss, I think, is that it may be less visible to users who (customize-group 'identica).

I'd like to replace the merge-text-attribute calls with just setting the face, so that you can customize any attributes of the face and have it be applied properly, but the docstring on merge-text-attribute suggests that it's not that simple.

Jason F. McBrayer <jfmcbrayer>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jfmcbrayer (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 12 Feb 2013 08:57:21 PM UTCjfmcbrayerAttached File-=>Added 0003-Update-handling-of-faces-to-respect-customization.patch, #27454

    Back to the top


    Powered by Savane 3.1-cleanup