bugWeeChat - Bugs: bug #38321, The charset plugin doesn't build...

 
 

bug #38321: The charset plugin doesn't build on OS X

Submitted by:  None
Submitted on:  Tue 12 Feb 2013 11:46:09 PM UTC  
 
Category: compilationSeverity: 3 - Normal
Item Group: compile/installStatus: Fixed
Privacy: PublicAssigned to: Sebastien Helleu <flashcode>
Originator Name: Øyvind Ingebrigtsen ØvergaardOriginator Email: -unavailable-
Open/Closed: ClosedRelease: 0.4.0
IRC nick: oyvindio

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 14 Feb 2013 01:43:00 PM UTC, comment #1:

Thanks for the patch, committed.

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Tue 12 Feb 2013 11:46:09 PM UTC, original submission:

The charset plugin is not built on OS X because cmake thinks libiconv isn't available, which it is (on 10.8.2 at least, it is in /usr/lib).

I was trying to figure this out a while ago, and discovered that swapping the order of the CHECK_LIBRARY_EXISTS calls in cmake/FindIconv.cmake (oddly) caused cmake to find libiconv like it should.
I took a closer look at this today, and discovered that if the first CHECK_LIBRARY_EXISTS call fails, the second call doesn't actually set ICONV_FOUND to true for some reason (which causes cmake to think that the library isn't available).
I have attached a patch (fix-libiconv-checks.patch) that resolves this problem by altering the check logic such that both checks actually matter.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #27455:  fix-libiconv-checks.patch added by None (912B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by flashcode (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 20 May 2013 09:01:47 AM UTCflashcodeOpen/ClosedOpen=>Closed
    Thu 14 Feb 2013 01:43:00 PM UTCflashcodeCategoryplugins=>compilation
      StatusNone=>Fixed
      Assigned toNone=>flashcode
    Tue 12 Feb 2013 11:46:09 PM UTCNoneAttached File-=>Added fix-libiconv-checks.patch, #27455

    Back to the top


    Powered by Savane 3.1-cleanup