buggNewSense GNU/Linux - Bugs: bug #39759, RecentChanges page images appear...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #39759: RecentChanges page images appear to be stretched

Submitted by:  Luis Felipe López Acevedo <sirgazil>
Submitted on:  Sun 11 Aug 2013 01:19:55 PM UTC  
 
Category: gNewSense 3Severity: 3 - Normal
Item Group: WebsiteStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Sun 08 Dec 2013 05:21:20 PM UTC, comment #7:

Could someone close this issue, please?

The stretched images bug was fixed for Galaxia 1.1.1 [1] and gNewSense website is already using Galaxia 1.2.0, which includes the fix [2].

Thanks.

[1] https://bitbucket.org/sirgazil/galaxia/issue/35/
[2] http://www.gnewsense.org/RecentChanges

Luis Felipe López Acevedo <sirgazil>
Thu 31 Oct 2013 03:20:31 AM UTC, comment #6:

Commit 3774778

Loïc Vaumerel <loicvaumerel>
Thu 31 Oct 2013 03:18:48 AM UTC, comment #5:

No problem.

I have created a new project on Gitorious.
https://gitorious.org/gnewsense-galaxia/gnewsense-galaxia

Description of the change:
Fix wrongly sized icons (stretched). Declare native size in the icons dictionary. Overwrite the dictionary in the ThemeBase class (_init_.py) with a new one declared in the Thene class (galaxia.py).

(file #29515, file #29516)

Loïc Vaumerel <loicvaumerel>
Wed 30 Oct 2013 02:51:21 PM UTC, comment #4:

Sorry for the late answer, Loïc.

Galaxia's source code is in a different repository:

https://bitbucket.org/sirgazil/galaxia

I don't have frequent access to computers anymore, so I'd suggest you to fork Galaxia's repository if you want and add any changes you consider useful for the project. Or copy the project and move it to a more free service like gitorious, launchpad, savannah. If you do, send me a link and I'll update Galaxia info in bitbucket to point to the new location.

Thanks for taking the time to explore this bug.

Best,

Luis Felipe López Acevedo <sirgazil>
Tue 29 Oct 2013 02:04:15 PM UTC, comment #3:

It seems MoinMoin version used is 1.9.3 (in picture path).
I quickly checked the source code of MoinMoin 1.9.7 (official site). I am not at home and don't have access to my gNewSense system.

I took the example of the deleted picture.
The URL is:
http://www.gnewsense.org/moin_static193//galaxia/img/moin-deleted.png
Size is 16px x 16px.

The problem is located in the MoinMoin/theme/__init__.py file in the "icons" dictionary (line 42).

icons = {
# key alticon filename w h
# ------------------------------------------------------
...
# RecentChanges
...
'deleted': (_("[DELETED]"), "moin-deleted.png", 60, 12),
...

It is the case for all icons of the RecentChanges section. All pictures have a size of 16px x 16px. They are all scaled in the "icons" dictionary with strange sizes.

I would change this _init_.py file to set the size to the native one (16x16) or the be close to the current one keeping the ratio (12x12).

As I don't have access to the source file I can not do the change.

Loïc Vaumerel <loicvaumerel>
Sat 26 Oct 2013 09:03:23 PM UTC, comment #2:

The page itself does not actually contain the table of changed pages [1]. That is generated by the RecentChanges macro. That's /usr/share/pyshared/MoinMoin/macro/RecentChanges.py. Maybe that module has a bug in how it determines the size of a theme's icons. I have not investigated further.

[1] http://www.gnewsense.org/RecentChanges?action=raw

Sam Geeraerts <samgee>
Project Administrator
Sat 26 Oct 2013 06:40:49 AM UTC, comment #1:

Hi,

I am not able to modify the page as it is immutable (page immuable in french).
I checked the source code. Height and width are set in the code.
e.g.:
<img alt="[MISE À JOUR]" height="12" src="/moin_static193//galaxia/img/moin-updated.png" title="[MISE À JOUR]" width="60" />
Set only the height and removing the width clause will solve the problem.

If I have access to the edit mode I can do the change.

Regards
Loïc

Loïc Vaumerel <loicvaumerel>
Sun 11 Aug 2013 01:19:55 PM UTC, original submission:

Here's the page:

http://www.gnewsense.org/RecentChanges

I submitted this issue to Galaxia issue tracker as well [1].

[1]: https://bitbucket.org/sirgazil/galaxia/issue/35/

Luis Felipe López Acevedo <sirgazil>

 

Attached Files
file #29515:  galaxia.py added by loicvaumerel (14kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by samgee (Posted a comment)
  • -unavailable- added by loicvaumerel (Posted a comment)
  • -unavailable- added by sirgazil (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 08 Dec 2013 09:15:43 PM UTCsamgeeStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Thu 31 Oct 2013 03:18:48 AM UTCloicvaumerelAttached File-=>Added galaxia.py, #29515
      Attached File-=>Added icons.test.page.txt, #29516
    Wed 28 Aug 2013 01:45:23 PM UTCsirgazilStatusNone=>Confirmed

    Back to the top


    Powered by Savane 3.1-cleanup