bugSimulavr: an AVR simulator - Bugs: bug #40598, Fix avr_message()

 
 

bug #40598: Fix avr_message()

Submitted by:  Markus Hitter <hitterm>
Submitted on:  Sat 16 Nov 2013 04:10:06 PM UTC  
 
Category: SimulationSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedComponent Version: simulavr

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 08 Oct 2014 05:00:31 PM UTC, comment #4:

Hi,

should be complete implemented. Ticket closed.

cu, Thomas

Thomas K. <tomk>
Project Administrator
Tue 19 Nov 2013 09:33:07 PM UTC, comment #3:

I reviewed the 6 patches, they all look good.

Petr Hluzin <petrh>
Project Member
Tue 19 Nov 2013 08:51:25 PM UTC, comment #2:

Patches 0001-* and 0002-* are identical (except for the commit ID).

Also attached a slightly refined 0004-* (accidently removed a message) and added 0005-*, which fixes a number of compilation warnings. The latter is independent and can be applied before or after the others.

(file #29666, file #29667)

Markus Hitter <hitterm>
Sat 16 Nov 2013 11:23:06 PM UTC, comment #1:

As I was into it, please find a bunch of additional patches simplifying and enhancing encapsulation of the code. Global variables are "eeek", aren't they?

(file #29639, file #29640, file #29641)

Markus Hitter <hitterm>
Sat 16 Nov 2013 04:10:06 PM UTC, original submission:

This is a minor issue, avr_message() did partially push its string into the wrong pipe. Please find a fix attached.

Markus Hitter <hitterm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by tomk (Posted a comment)
  • -unavailable- added by petrh (Posted a comment)
  • -unavailable- added by hitterm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 08 Oct 2014 05:00:31 PM UTCtomkStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Tue 19 Nov 2013 08:51:25 PM UTChittermAttached File-=>Added 0004-Use-avr_message-for-verbose-messages.patch, #29666
      Attached File-=>Added 0005-src-avrerror.h-fix-a-number-of-compilation-warnings.patch, #29667
    Sat 16 Nov 2013 11:23:06 PM UTChittermAttached File-=>Added 0002-src-avrerror.cpp-fix-MESSAGE-handling.patch, #29639
      Attached File-=>Added 0003-src-avrerror.cpp-simplify-plain-messages.patch, #29640
      Attached File-=>Added 0004-Use-avr_message-for-verbose-messages.patch, #29641
    Sat 16 Nov 2013 04:10:06 PM UTChittermAttached File-=>Added 0001-src-avrerror.cpp-fix-MESSAGE-handling.patch, #29632

    Back to the top


    Powered by Savane 3.1-cleanup