newsAdvanced Gtk+ Sequencer - News: Refactoring ags_channel.c

 
 
Latest News
Got segfault after a while of recording posted by jkraehemann, Thu 20 Sep 2018 03:04:31 PM UTC - 0 replies
Advanced Gtk+ Sequencer v2.0.0 - new major release posted by jkraehemann, Mon 10 Sep 2018 03:20:12 AM UTC - 0 replies
currently dealing with capture of soundcard posted by jkraehemann, Tue 04 Sep 2018 12:21:58 AM UTC - 0 replies
Advanced Gtk+ Sequencer v2.0.0-beta posted by jkraehemann, Fri 31 Aug 2018 10:43:05 AM UTC - 0 replies

Refactoring ags_channel.c

Item posted by Joël Krähemann <jkraehemann> on Sat 23 Dec 2017 11:47:54 AM UTC.

Some key functions are going to be refactored, these are:

  • ags_channel_recursive_play_init()
  • ags_channel_recursive_play()
  • ags_channel_recursive_reset_recall_ids()
  • ags_channel_tillrecycling_cancel()

The problem with them is they are really old and don't do their job correct. They have redundant code and were never intended to run in a non thread-safe context. This issue is going to be targeted by the new functions:

  • ags_channel_get_level()
  • ags_channel_recursive_reset_recall_id()
  • ags_channel_recursive_init()
  • ags_channel_recursive_run()
  • ags_channel_recursive_cancel()

One more problem with the old code is the schema wasn't correct applied recursive. Causing some SIGSEGV, however the model is mature and it is possible to fix it.

AgsRecyclingContext thread-safe

The AgsRecyclingContext has got its very own mutex. Thought it is not provided by AgsMutexManager, you can access it by the structs field.

Sorry for screwing things

Running the user interface asynchronously is really tough. There had to be added many mutex locks. And I screwed things, sorry. But this is a great occasion to solve some really old problems the engine had.


by Joël

No messages in Refactoring ags_channel.c

 

Back to the top


Powered by Savane 3.3