patchmldonkey, a multi-networks file-sharing client - Patches: patch #3551, new gtk2 gui

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #3551: new gtk2 gui

Submitter:  su_blanc <su_blanc>
Submitted:  Mon 06 Dec 2004 06:33:50 AM UTC
   
 
Category:  Improved interfaces Priority:  1 - Later
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Sun 20 Mar 2005 07:41:18 PM UTC, comment #9: 

There are three bug reports about this GUI:
bug #12390, bug #12391 and bug #12392

spiralvoice <spiralvoice>
Group administrator
Wed 02 Mar 2005 08:52:13 PM UTC, comment #8: 

applied in CVS 2-5-30

spiralvoice <spiralvoice>
Group administrator
Fri 25 Feb 2005 10:47:34 PM UTC, comment #7: 

To confirm it, could you try this:
- delete/rename mlgui.ini and mlgui.ini.old
- start mlgui
- check the options panel (should be nothing)
- close properly mlgui
- restart mlgui
- check the options panel (should be ok)

===============================================
did what you suggested, after second and third restart
the options panel stays empty :-( although mlgui.ini exists

spiralvoice <spiralvoice>
Group administrator
Sun 23 Jan 2005 04:20:35 PM UTC, comment #6: 

tell me what you want and i can see how to implement it.
The buid system is 'chaotic' because of the multiple GUIs and gtk versions used.

su_blanc <su_blanc>
Group Member
Sun 23 Jan 2005 01:01:57 PM UTC, comment #5: 

for the gui this seems to be something that is realy needed, but the buildsystem is a bit chaotic (a helping hand would be usefull there :) ), especially for the gui, so this has to wait

Amorphous <amorphous>
Wed 22 Dec 2004 06:24:42 AM UTC, comment #4: 

Ok, I think I got it...
But if what I guess is correct this bug is present since 2.5.22 and should be also for newgui, old gtk, etc...
In fact since Options.load has been changed
from:

opfile.file_rc <- really_load opfile.file_name opfile.file_sections
   with
     Not_found -> lprintf "No %s found\n" opfile.file_name

to

opfile.file_rc <- really_load opfile.file_name opfile.file_sections
   with
Not_found | Sys_error _ -> lprintf "No %s found\n" opfile.file_name

'Sys_error e' was the condition to create the gui option file at startup and since this error is not raised any more (due to the above changed), it doesn't work because we create the option file only when exiting.

To confirm it, could you try this:
- delete/rename mlgui.ini and mlgui.ini.old
- start mlgui
- check the options panel (should be nothing)
- close properly mlgui
- restart mlgui
- check the options panel (should be ok)

If yes it's only 2 lines to change in guiMain.ml

Thanks

Note : nothing else?

su_blanc <su_blanc>
Group Member
Tue 07 Dec 2004 01:40:28 AM UTC, comment #3: 

Do you mean that the setting dialog does not show the 2 icons Main & Interfaces. Here it's ok. Under the Interfaces/MLgui i can set 'Hostname' and 'MLgui port' options.
I have to investigate this bug because even if the core options are not loaded, the gui options shall be...

su_blanc <su_blanc>
Group Member
Mon 06 Dec 2004 10:23:51 PM UTC, comment #2: 

Its currently not possible on Debian unstable to compile a static GTK2 GUI due to missing libatk-1.0.a:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=283862

spiralvoice <spiralvoice>
Group administrator
Mon 06 Dec 2004 10:13:41 PM UTC, comment #1: 

Some infos:
This patch is for CVS 2-5-29 (don't use the core!)
On Debian you will need package librsvg2-dev and its dependencies to compile the new GUI.

One problem occured: The core is not running on localhost but the GUI tries to connect to that machine as default. In this situation it is not possible to use the settings dialog. The window comes up but there are no icons to choose in the listfield on the left side so I could not configure the machine the GUI should connect to. I stopped the GUI and edited mlgui.ini by hand, restarted the GUI and everything was fine. Looking nice but I still have to dig into it more.

spiralvoice <spiralvoice>
Group administrator
Mon 06 Dec 2004 06:33:50 AM UTC, original submission:  

to replace the current gtk2 branch.
the patch consists in the 2 files :
new_gtk2.patch.gz
rsvg_icons_set.patch.gz

General notes :
No more classes ;-)
column sizes are now saved
options/settings are now sorted (i tried to follow the description in the wiki : http://mldonkey.berlios.de/modules.php?name=Wiki&pagename=ToDo)
 
All strings are utf8 encoded (it means we send back to the core utf8 strings : possible bugs here?)
bug #3675 : "max hits" still doesn't work.
bug #2443 : Source-state error in GUI should be corrected.
bug #3179 : Right click to file option save doesn't show all file names is ok.
bug #3445 : Change the search-for field into a combo box (now uses an entry_completion)
bug #3476 : Remember current tab on exit
bug #4316 : Better GUI for identifying what files are in good states (color gradation is used)
bud#4154 : Handling of foreign characters (sould be ok from the gui side)

for the win32 version, a "systray" is now included.

i didn't spend too much time in debug. so comments/feedback are more than welcome.

Warning : I made some reorganisation in the mldonkey tree.

su_blanc <su_blanc>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8474:  3551_1_29.patch.gz added by spiralvoice (366KiB - application/x-gzip - this patch replaces new_gtk2.patch.gz and applies cleanly against CVS 2-5-29)
file #8136:  rsvg_icons_set.patch.gz added by su_blanc (312KiB - application/x-gzip)
file #8129:  new_gtk2.patch.gz added by su_blanc (368KiB - application/x-gzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-03-02 spiralvoice StatusPostponed Done
    Open/ClosedOpen Closed
2005-02-25 spiralvoice Attached File- Added 3551_1_29.patch.gz, #4246
2005-01-23 amorphous StatusNone Postponed
2004-12-06 su_blanc Attached File- Added rsvg_icons_set.patch.gz, #3920
2004-12-06 su_blanc Attached File- Added new_gtk2.patch.gz, #3919

Back to the top

Powered by Savane 3.13-d3ae.
Corresponding source code