patchmldonkey, a multi-networks file-sharing client - Patches: patch #4109, EDK: Improve update_server_list

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4109: EDK: Improve update_server_list

Submitter:  spiralvoice <spiralvoice>
Submitted:  Sat 18 Jun 2005 08:20:34 PM UTC
   
 
Category:  Improved interfaces Priority:  5 - Normal
Status:  Done Assigned to:  amorphous
Open/Closed:  Closed

Jump to the original submission

Thu 07 Jul 2005 06:19:10 PM UTC, comment #10: 

That is likely, however Overnet is working well without
MLDonkey being able to read these bcp messages.
I will close this patch now, the error message can be
activated with a certain verbosity for later solving.

spiralvoice <spiralvoice>
Group administrator
Tue 05 Jul 2005 09:11:32 PM UTC, comment #9: 

Is it possible that one of these is to contact the client by Overnet while the other one is for regular ed2k ?

Adrien <camarade_tux>
Tue 05 Jul 2005 08:44:28 PM UTC, comment #8: 

Yes, these are ports. But they must come from updated Overnet software.
MLDonkey can not interpret the bcp links and therefore prints
this error message.
The log message is deactivated in 2.5.30.17 ;-)

spiralvoice <spiralvoice>
Group administrator
Tue 05 Jul 2005 07:56:05 PM UTC, comment #7: 

Ill formed bcp: [bcp://b85e5bcbb7ef437e989b8dfb540f7e7d:201.133.236.153:4695:4662]

:4695:4662

To my mind these numbers are port numbers.


I thought bcp:// had something to do with overnet and I didn't noticed that earlier.




Anyway, you're right. If this had something to do with this, I wonder how this could happen on 2.5.30.16: http://www.mldonkey.org/phpbb2/viewtopic.php?p=31958& (a post you already read)

Adrien <camarade_tux>
Tue 05 Jul 2005 07:38:09 PM UTC, comment #6: 

"but I wonder how the ports are added."
What do you mean by "ports"?
The log messages have nothing to do with this patch, btw.

spiralvoice <spiralvoice>
Group administrator
Tue 05 Jul 2005 06:24:12 PM UTC, comment #5: 

But, now in log (verbosity = nothing), I get :



""CONNECTION FROM GUI
Using protocol 32 for communications with the GUI
Network.room_users not implemented by Private
Ill formed bcp: [bcp://b85e5bcbb7ef437e989b8dfb540f7e7d:201.133.236.153:4695:4662]
Options correctly saved on localtime:  5/ 7, 19:09:26
Ill formed bcp: [bcp://4ef58c55bbf5f12e57eee115c09780a9:68.93.195.130:12117:4662]
Ill formed bcp: [bcp://946eadf6bd735cf1f68b0f289fe44ed6:82.75.231.219:5765:5662]
Ill formed bcp: [bcp://95397676bcc8fb8ccedc23250e39f441:80.167.73.175:4869:4662]
Ill formed bcp: [bcp://9a0202cac5cef721683320e2affc28df:172.214.189.172:5355:4662]

....

Ill formed bcp: [bcp://95397676bcc8fb8ccedc23250e39f441:80.167.73.175:4869:4662]
Ill formed bcp: [bcp://4ef58c55bbf5f12e57eee115c09780a9:68.93.195.130:12117:4662]
Ill formed bcp: [bcp://3d2341e99598ae7c8ddd97d48a12afab:80.3.242.244:11137:8012]
Ill formed bcp: [bcp://9c7db084f350ebf477873f50a7734907:172.182.69.20:7765:4662]
Ill formed bcp: [bcp://7f430973355e4077720e3f91177e10fa:213.186.251.171:6946:4662]
Ill formed bcp: [bcp://9a0202cac5cef721683320e2affc28df:172.214.189.172:5355:4662]
Ill formed bcp: [bcp://946eadf6bd735cf1f68b0f289fe44ed6:82.75.231.219:5765:5662]
Options correctly saved on localtime:  5/ 7, 19:24:26
************* should browse  *********
**************************************
       TRYING TO CONTACT FRIEND        
************* should browse  *********
**************************************""




I'm not really annoyed. I believe the patch is not faulty, but I wonder how the ports are added.

Adrien <camarade_tux>
Tue 05 Jul 2005 06:21:14 PM UTC, comment #4: 

As far as I'm concerned, there are 72 servers in my list; all of them are working and both update_server_list_client and update_server_list_server are set to false.
update_nodes is set to true.

cs says 12% of my downloads are from overnet.
In the past days, I was approximately 20% (I have now 1300 sources)


I'm using 2.5.30.16+#4109 (this one) under windows.



with verbosity only set to "ms", log returns lots of:

"MESSAGE TO SERVER:
QUERY LOCATION OF 381D1C407650A359D8AE893403881FXX

Message from server:
INFO:
users: 28340 files: 2350063


Message from server:
INFO:
users: 364265 files: 52111276


Message from server:
LOCATION OF 381D1C407650A359D8AE893403881FXX
   83.49.61.75 : 14662
   80.35.46.218 : 4662
   200.112.141.183 : 9662
   69.133.136.42 : 4662
   82.159.29.165 : 4662
   213.98.16.8 : 4662
   83.43.147.146 : 4994


Message from server:........."

I have no problem with this patch and I'm really satisfied.

Adrien <camarade_tux>
Thu 23 Jun 2005 02:43:57 PM UTC, comment #3: 

There is no activity at all shown with verbosity=ms (only bittorrent, my only other active network). Is that behaviour normal?

White_FrosT
Thu 23 Jun 2005 02:19:14 PM UTC, comment #2: 

Could this patch be the reason that my server list is empty?
Updated core only from 2.5.30.16 to the 20/6 cvs.

White_FrosT
Mon 20 Jun 2005 06:58:21 PM UTC, comment #1: 

Applied 2005/06/20

spiralvoice <spiralvoice>
Group administrator
Sat 18 Jun 2005 08:20:34 PM UTC, original submission:  

See task #4194 for more details.

spiralvoice <spiralvoice>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8979:  update_server.patch added by spiralvoice (13KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-07-07 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
2005-06-22 spiralvoice Assigned toNone amorphous
2005-06-18 spiralvoice Attached File- Added update_server.patch, #4741

Back to the top

Powered by Savane 3.13-d3ae.
Corresponding source code